Fix ResetPasswordTest on chrome 128 #32710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes keycloak#32514 closes keycloak#32478 closes keycloak#32477 closes keycloak#32678 closes keycloak#32542 closes keycloak#32678 closes keycloak#32541 Signed-off-by: mposolda <[email protected]>
2c2d334 to
55d45b9
Compare
wojnarfilip
approved these changes
Sep 6, 2024
Contributor
wojnarfilip
left a comment
There was a problem hiding this comment.
Thank you for investigating this and coming up with the solution to improve test stability. LGTM.
This was referenced Sep 6, 2024
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.webauthn.registration.passwordless.PwdLessUserVerRegTest#discouragedNoVerificationKeycloak CI - WebAuthn IT (chrome) |
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.webauthn.registration.passwordless.PwdLessUserVerRegTest#discouragedNoVerificationKeycloak CI - WebAuthn IT (chrome) |
Contributor
Author
|
@wojnarfilip Thanks! |
This was referenced Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #32514
closes #32478
closes #32477
closes #32678
closes #32542
closes #32678
closes #32541
@miquelsi @wojnarfilip Are you able to review please?
I was not able to reproduce locally with Chrome 126 + ChromeDriver 125 and tests always passed. After upgrade to Chrome 128 and chromeDriver 128, I was able to reproduce flakiness locally. So it looks that chrome+chromeDriver upgrade caused this on GH actions, which is probably why this test started to fail just recently.
After this change, I am not able to see any flakiness locally, so I think this fix will help on GH actions as well.
This should help with all the
ResetPasswordTestfailures and flakiness. It looks that chrome update to 128 happened around 29th August on GH actions as this is when the issues started to be reported. If there are multiple links where this strange behaviour happens, we can possibly consider moving "retry" somewhere to the framework (maybeUIUtils.clickLink) instead of handling just this single link.