Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove ProxyClassLoader and PlatformProvider returning script classloader #32806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stianst merged 1 commit into from
Sep 11, 2024
Merged

Remove ProxyClassLoader and PlatformProvider returning script classloader #32806

stianst merged 1 commit into from
Sep 11, 2024

Conversation

@stianst
Copy link
Contributor

@stianst stianst commented Sep 11, 2024

Closes #32804

Signed-off-by: stianst [email protected]

@stianst stianst requested review from a team as code owners September 11, 2024 11:53
This was referenced Sep 11, 2024
Closed
Closed
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Sep 11, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

keycloak-github-bot bot commented Sep 11, 2024

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.webauthn.registration.ResidentKeyRegisterTest#residentKeyRequiredCorrect

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected RegisterPage but was Sign in to test (https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?response_type=code&client_id=test-app&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Fmaster%2Fapp%2Fauth&state=48968c7f-2283-4d7c-a323-133f15e1fa27&scope=openid)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

mposolda
mposolda approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@mposolda mposolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stianst Looks good, Thanks!

This was needed just for the Keycloak distribution on Wildfly. With that being removed, the dedicated classloader for scripts is not needed anymore.

@stianst stianst merged commit 40049f3 into keycloak:main Sep 11, 2024
@stianst stianst deleted the fix-32804 branch November 18, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mposolda mposolda mposolda approved these changes

+1 more reviewer

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test team/cloud-native team/core-clients team/core-iam

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove org.keycloak.utils.ProxyClassLoader

2 participants

@stianst @mposolda