Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove legacy cookies #32130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ahus1 merged 2 commits into from
Aug 15, 2024
Merged

Remove legacy cookies #32130

ahus1 merged 2 commits into from
Aug 15, 2024

Conversation

@stianst
Copy link
Contributor

@stianst stianst commented Aug 14, 2024 •
edited
Loading

Closes #16770

Signed-off-by: stianst [email protected]

@stianst stianst force-pushed the remove-legacy-cookies branch from bb824ab to 4582f09 Compare August 14, 2024 14:30
@keycloak-github-bot keycloak-github-bot bot mentioned this pull request Aug 14, 2024
Closed
@stianst stianst force-pushed the remove-legacy-cookies branch 2 times, most recently from 92c4a56 to a397f38 Compare August 15, 2024 09:24
@stianst stianst marked this pull request as ready for review August 15, 2024 09:24
@stianst stianst requested review from a team as code owners August 15, 2024 09:24
@stianst stianst linked an issue Aug 15, 2024 that may be closed by this pull request
Cookie refactoring #26503
Closed
@stianst stianst requested review from ahus1, jonkoops and vmuzikar August 15, 2024 09:26
@stianst stianst force-pushed the remove-legacy-cookies branch from a397f38 to 0e80c3c Compare August 15, 2024 10:01
jonkoops
jonkoops suggested changes Aug 15, 2024
View reviewed changes
@stianst stianst force-pushed the remove-legacy-cookies branch from 0e80c3c to a449760 Compare August 15, 2024 11:32
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Aug 15, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

keycloak-github-bot bot commented Aug 15, 2024

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.broker.KcOidcBrokerTest#testPostBrokerLoginFlowWithOTP_bruteForceEnabled

Keycloak CI - Java Distribution IT (windows-latest - temurin - 17)

java.lang.AssertionError: Did not find the event of expected type USER_DISABLED_BY_TEMPORARY_LOCKOUT. Events present: [IDENTITY_PROVIDER_POST_LOGIN_ERROR, IDENTITY_PROVIDER_POST_LOGIN_ERROR]
	at org.junit.Assert.fail(Assert.java:89)
	at org.keycloak.testsuite.AssertEvents$ExpectedEvent.assertEvent(AssertEvents.java:399)
	at org.keycloak.testsuite.broker.AbstractAdvancedBrokerTest.testPostBrokerLoginFlowWithOTP_bruteForceEnabled(AbstractAdvancedBrokerTest.java:584)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
...

Report flaky test

jonkoops
jonkoops approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@jonkoops jonkoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ahus1
ahus1 approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR and all the great discussions that lead to this simple-to-use solution.

@ahus1 ahus1 merged commit 310824c into keycloak:main Aug 15, 2024
@stianst stianst deleted the remove-legacy-cookies branch August 15, 2024 13:27
@ahus1 ahus1 mentioned this pull request Aug 15, 2024
Closed
@evegufy evegufy mentioned this pull request Nov 11, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahus1 ahus1 ahus1 approved these changes

@vmuzikar vmuzikar Awaiting requested review from vmuzikar

+2 more reviewers

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

@jonkoops jonkoops jonkoops approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test team/cloud-native team/core-clients team/core-iam

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cookie refactoring Remove legacy cookies

3 participants

@stianst @jonkoops @ahus1