Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove redirect_uri support from OIDC logout endpoint #32339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ahus1 merged 2 commits into from
Aug 30, 2024
Merged

Remove redirect_uri support from OIDC logout endpoint #32339

ahus1 merged 2 commits into from
Aug 30, 2024

Conversation

@jonkoops
Copy link
Contributor

@jonkoops jonkoops commented Aug 22, 2024

Closes #10983

@jonkoops jonkoops requested review from a team as code owners August 22, 2024 11:30
@jonkoops jonkoops requested review from mposolda and sschu August 22, 2024 11:37
@jonkoops jonkoops marked this pull request as draft August 22, 2024 11:58
@keycloak-github-bot keycloak-github-bot bot mentioned this pull request Aug 22, 2024
Closed
sschu
sschu reviewed Aug 27, 2024
View reviewed changes
Copy link
Contributor

@sschu sschu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I am fine with removing the legacy support, my only point would be the aforementioned marking of the endpoint as deprecated.

@jonkoops jonkoops force-pushed the rm-legacy-redirect-uri branch 2 times, most recently from 4e08488 to 483c8c2 Compare August 27, 2024 11:14
@jonkoops jonkoops requested a review from sschu August 27, 2024 11:15
keycloak-github-bot[bot]

This comment was marked as outdated.

Sign in to view

@keycloak-github-bot

This comment was marked as outdated.

Sign in to view
sschu
sschu approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@sschu sschu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jonkoops jonkoops marked this pull request as ready for review August 27, 2024 13:10
abstractj
abstractj previously approved these changes Aug 27, 2024
View reviewed changes
ahus1
ahus1 requested changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Found one typo in the migration guide. Probably worth mentioning this is the release notes as well.

@jonkoops jonkoops force-pushed the rm-legacy-redirect-uri branch from 483c8c2 to 53bdb17 Compare August 30, 2024 11:10
@jonkoops jonkoops requested review from abstractj and ahus1 August 30, 2024 11:12
ahus1
ahus1 previously approved these changes Aug 30, 2024
View reviewed changes
ahus1
ahus1 reviewed Aug 30, 2024
View reviewed changes
@ahus1 ahus1 enabled auto-merge (squash) August 30, 2024 11:16
@ahus1 ahus1 self-assigned this Aug 30, 2024
@keycloak-github-bot keycloak-github-bot bot mentioned this pull request Aug 30, 2024
Closed
@keycloak-github-bot
Copy link

keycloak-github-bot bot commented Aug 30, 2024

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.LevelOfAssuranceFlowTest#testWithOTPAndRecoveryCodesAtLevel2

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError: Event expected
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertNotNull(Assert.java:713)
	at org.keycloak.testsuite.AssertEvents.poll(AssertEvents.java:87)
...

Report flaky test

org.keycloak.testsuite.webauthn.registration.WebAuthnOtherSettingsTest#excludeCredentials

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected RegisterPage but was Sign in to test (https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?response_type=code&client_id=test-app&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Fmaster%2Fapp%2Fauth&state=890fec95-0c9d-4bb6-9e21-70daef96f00e&scope=openid)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Aug 30, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ahus1 ahus1 merged commit 2d17024 into keycloak:main Aug 30, 2024
@jonkoops jonkoops deleted the rm-legacy-redirect-uri branch August 30, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedroigor pedroigor pedroigor approved these changes

@ahus1 ahus1 ahus1 approved these changes

@mposolda mposolda Awaiting requested review from mposolda

@abstractj abstractj Awaiting requested review from abstractj

+2 more reviewers

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

@sschu sschu sschu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ahus1 ahus1

Labels

flaky-test team/cloud-native team/core-clients team/core-iam

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove redirect_uri support from OIDC logout endpoint

5 participants

@jonkoops @abstractj @pedroigor @sschu @ahus1