Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Ensure componentsByParentAndType in CachedRealm is returned as a conc… #33452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pedroigor merged 1 commit into from
Oct 1, 2024
Merged

Ensure componentsByParentAndType in CachedRealm is returned as a conc… #33452

pedroigor merged 1 commit into from
Oct 1, 2024

Conversation

@sguilhen
Copy link
Contributor

@sguilhen sguilhen commented Oct 1, 2024

…urrent multi-valued map

Closes #30235

@sguilhen sguilhen requested a review from a team as a code owner October 1, 2024 19:54
@pedroigor pedroigor enabled auto-merge (rebase) October 1, 2024 20:20
@pedroigor pedroigor merged commit 9b7cf9d into keycloak:main Oct 1, 2024
This was referenced Oct 1, 2024
Closed
Closed
Closed
Closed
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Oct 1, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

keycloak-github-bot bot commented Oct 1, 2024

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.webauthn.registration.PolicyJsInjectionTest#requireResidentKey

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected RegisterPage but was Sign in to test (https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?response_type=code&client_id=test-app&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Fmaster%2Fapp%2Fauth&state=2e7db21d-0d92-448e-b166-b26403adc314&scope=openid)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

org.keycloak.testsuite.forms.RegisterTest#registerUserSuccessTermsAcceptance

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError: Expected RegisterPage but was Sign in to test (https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?response_type=code&client_id=test-app&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Fmaster%2Fapp%2Fauth&state=c317c5e0-675c-4e00-9646-e50297cce965&scope=openid)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

@sguilhen sguilhen deleted the 30235-usermodel-flaky-test branch October 25, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedroigor pedroigor pedroigor approved these changes

+1 more reviewer

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flaky test: org.keycloak.testsuite.model.user.UserModelTest#testAddRemoveUserConcurrent

2 participants

@sguilhen @pedroigor