Adding retry when clicking on rememberMe checkbox on the loginPage du…#33563
Merged
mposolda merged 1 commit intokeycloak:mainfrom Oct 4, 2024
Merged
Adding retry when clicking on rememberMe checkbox on the loginPage du…#33563mposolda merged 1 commit intokeycloak:mainfrom
mposolda merged 1 commit intokeycloak:mainfrom
Conversation
…ring tests closes keycloak#32476 closes keycloak#32677 closes keycloak#32767 closes keycloak#33132 closes keycloak#32550 Signed-off-by: mposolda <[email protected]>
Contributor
Author
|
@graziang Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ring tests
closes #32476
closes #32677
closes #32767
closes #33132
closes #32550
This is again problem with Chrome 128. After click to checkbox like "rememberMe" on login page, the click is sometimes not taken into account and should be repeated. This helps to fix all flaky tests of
LoginTest. It passed 20 times in a row with Chrome in my branch - https://github.com/mposolda/keycloak/actions/runs/11176736792/job/31070953971