Add check to ensure that no unstaged proto.lock files exist on PRs is… #33592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sued against release/26.x branches Closes keycloak#33566 Signed-off-by: Ryan Emerson <[email protected]>
mhajas
reviewed
Oct 10, 2024
Contributor
mhajas
left a comment
There was a problem hiding this comment.
Thank you for the PR @ryanemerson, I added one comment.
ryanemerson
added a commit
to ryanemerson/keycloak
that referenced
this pull request
Oct 15, 2024
…sued against release/26.x branches (keycloak#33592) Closes keycloak#33566 Signed-off-by: Ryan Emerson <[email protected]>
mhajas
pushed a commit
that referenced
this pull request
Oct 15, 2024
…sued against release/26.x branches (#33592) (#33952) Closes #33566 Signed-off-by: Ryan Emerson <[email protected]>
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33566
This also needs to be backported to
release/26.0.The Keycloak build is now always executed with the
-DcommitProtoLockChanges=trueso that the various**/proto.lockfiles are created/updated. We then fail the "build" job if there exists uncommitted changes to any**/proto.lockfiles. This will not impact themainbranch as noproto.lockfiles should exist in the repository, however it will ensure that any changes toproto.lockfiles in the release branches must be committed in order for CI to continue.