Fix incorrect filter in docker protocol #33797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes keycloak#33776 Signed-off-by: rmartinc <[email protected]>
mposolda
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33776
There was an error adding the DPoP transient mapper. A line was added to filter it for the docker protocol but the
instanceofwas not OK (it was set tomapperwhen it should be tomapper.getValue()). But the PR is changing the utils to only add the transient mapper if the client is OIDC (adding it to a saml or docker client makes no sense). The docker test is improved to pull a little image fromdocker.ioand push it to the keycloak protected registry. This way after the login the permissions are also tested.