Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix amr test #33048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ahus1 merged 1 commit into from
Sep 20, 2024
Merged

Fix amr test #33048

ahus1 merged 1 commit into from
Sep 20, 2024

Conversation

@graziang
Copy link
Contributor

@graziang graziang commented Sep 18, 2024 •
edited
Loading

Closes #26117

Sometimes the 60 second time offset exceeded the default Client Login Timeout (1 min) by 1 ms.

@graziang graziang requested review from a team as code owners September 18, 2024 09:58
jonkoops
jonkoops approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@jonkoops jonkoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Sep 18, 2024
Closed
Closed
Closed
Closed
@keycloak-github-bot
Copy link

keycloak-github-bot bot commented Sep 18, 2024

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.CustomRegistrationFlowTest#registerUserSuccess

Keycloak CI - Forms IT (chrome)

java.lang.IllegalArgumentException: No enum constant org.keycloak.testsuite.pages.AppPage.RequestType.Sign in to test
	at java.base/java.lang.Enum.valueOf(Enum.java:293)
	at org.keycloak.testsuite.pages.AppPage$RequestType.valueOf(AppPage.java:56)
	at org.keycloak.testsuite.pages.AppPage.getRequestType(AppPage.java:45)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Sep 18, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ahus1 ahus1 self-assigned this Sep 18, 2024
@ahus1 ahus1 enabled auto-merge (rebase) September 18, 2024 11:40
mposolda
mposolda approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@mposolda mposolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@graziang Nice, Thanks!

@graziang @ahus1
Fix amr test
bc4ac57 
Closes keycloak#26117

Signed-off-by: Giuseppe Graziano <[email protected]>
@ahus1 ahus1 merged commit 849ca3e into keycloak:main Sep 20, 2024
This was referenced Sep 20, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mposolda mposolda mposolda approved these changes

+2 more reviewers

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

@jonkoops jonkoops jonkoops approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ahus1 ahus1

Labels

flaky-test team/cloud-native team/core-clients team/core-iam

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flaky test: org.keycloak.testsuite.oidc.AuthenticationMethodReferenceTest#testAmrPastMaxAge

4 participants

@graziang @jonkoops @mposolda @ahus1