Action expired error occurs when accessing regular registration page … #33086

sguilhen · 2024-09-19T01:33:45Z

…with Organizations enabled

…with Organizations enabled Closes keycloak#33064 Signed-off-by: Stefan Guilhen <[email protected]>

sguilhen · 2024-09-19T02:53:59Z

js/apps/admin-ui/cypress/e2e/authentication_test.spec.ts


  it("Should display the default browser flow diagram", () => {
+    sidebarPage.goToRealm("master");
+    sidebarPage.goToAuthentication();


Had to switch to master for this test because when orgs are enabled the default browser flow is changed for every new realm created, so the edges in the diagram connect different executions.

I've tried to add all new diagram connections to the test, but we have two conditional executions in this flow and they have the same text, so cypress complains about multiple elements with the same text.

Using master for this test seemed to me the best way to get the issue fixed, and consequently all PRs unblocked. We can possibly have a separate issue to revisit this test and see if we can change it to take into account the changes to the browser flow introduced by the orgs which are now enabled by default.

Logging an issue will do.

keycloak-github-bot

Unreported flaky test detected, please review

keycloak-github-bot · 2024-09-19T03:20:03Z

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.webauthn.WebAuthnIdlessTest#testWebAuthnIDLessLogin

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Event expected
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertNotNull(Assert.java:713)
	at org.keycloak.testsuite.AssertEvents.poll(AssertEvents.java:91)
...

Report flaky test

org.keycloak.testsuite.webauthn.registration.passwordless.PwdLessOtherSettingsTest#defaultValues

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected RegisterPage but was Sign in to test (https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?response_type=code&client_id=test-app&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Fmaster%2Fapp%2Fauth&state=e615df26-02dd-47ff-a02e-9d300a7cd4a5&scope=openid)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

keycloak-github-bot · 2024-09-19T08:36:37Z

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.webauthn.WebAuthnIdlessTest#testWebAuthnIDLessLogin

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Event expected
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertNotNull(Assert.java:713)
	at org.keycloak.testsuite.AssertEvents.poll(AssertEvents.java:91)
...

Report flaky test

org.keycloak.testsuite.webauthn.registration.passwordless.PwdLessOtherSettingsTest#defaultValues

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected RegisterPage but was Sign in to test (https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?response_type=code&client_id=test-app&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Fmaster%2Fapp%2Fauth&state=e615df26-02dd-47ff-a02e-9d300a7cd4a5&scope=openid)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

keycloak-github-bot

Unreported flaky test detected, please review

keycloak-github-bot

Unreported flaky test detected, please review

keycloak-github-bot · 2024-09-19T12:58:11Z

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.webauthn.WebAuthnIdlessTest#testWebAuthnIDLessLogin

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Event expected
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertNotNull(Assert.java:713)
	at org.keycloak.testsuite.AssertEvents.poll(AssertEvents.java:91)
...

Report flaky test

org.keycloak.testsuite.webauthn.registration.passwordless.PwdLessOtherSettingsTest#defaultValues

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected RegisterPage but was Sign in to test (https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?response_type=code&client_id=test-app&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Fmaster%2Fapp%2Fauth&state=e615df26-02dd-47ff-a02e-9d300a7cd4a5&scope=openid)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

mhajas

Thanks for the fixes @sguilhen and @rmartinc

keycloak-github-bot

Unreported flaky test detected, please review

keycloak-github-bot · 2024-09-19T14:37:53Z

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.LevelOfAssuranceFlowTest#testWithOTPAndRecoveryCodesAtLevel2

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError: Event expected
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertNotNull(Assert.java:713)
	at org.keycloak.testsuite.AssertEvents.poll(AssertEvents.java:91)
...

Report flaky test

Signed-off-by: Jon Koops <[email protected]>

vramik

Thanks everyone!

mhajas

Thanks for the fixes @sguilhen @rmartinc @jonkoops

- Disables the remote operator tests, which will have to be fixed later. - Fixes the action expired error which occurs when accessing regular registration page with Organizations enabled. - Fixes a race condition in the test suite causing sporadic failures. Closes keycloak#33064 Signed-off-by: Stefan Guilhen <[email protected]> Signed-off-by: rmartinc <[email protected]> Signed-off-by: Jon Koops <[email protected]> Co-authored-by: rmartinc <[email protected]> Co-authored-by: Jon Koops <[email protected]>

- Disables the remote operator tests, which will have to be fixed later. - Fixes the action expired error which occurs when accessing regular registration page with Organizations enabled. - Fixes a race condition in the test suite causing sporadic failures. Closes #33064 Signed-off-by: Stefan Guilhen <[email protected]> Signed-off-by: rmartinc <[email protected]> Signed-off-by: Jon Koops <[email protected]> Co-authored-by: rmartinc <[email protected]> Co-authored-by: Jon Koops <[email protected]>

- Disables the remote operator tests, which will have to be fixed later. - Fixes the action expired error which occurs when accessing regular registration page with Organizations enabled. - Fixes a race condition in the test suite causing sporadic failures. Closes keycloak#33064 Signed-off-by: Stefan Guilhen <[email protected]> Signed-off-by: rmartinc <[email protected]> Signed-off-by: Jon Koops <[email protected]> Co-authored-by: rmartinc <[email protected]> Co-authored-by: Jon Koops <[email protected]>

- Disables the remote operator tests, which will have to be fixed later. - Fixes the action expired error which occurs when accessing regular registration page with Organizations enabled. - Fixes a race condition in the test suite causing sporadic failures. Closes #33064 Signed-off-by: Stefan Guilhen <[email protected]> Signed-off-by: rmartinc <[email protected]> Signed-off-by: Jon Koops <[email protected]> Co-authored-by: rmartinc <[email protected]> Co-authored-by: Jon Koops <[email protected]>

Action expired error occurs when accessing regular registration page …

b6a4a6d

…with Organizations enabled Closes keycloak#33064 Signed-off-by: Stefan Guilhen <[email protected]>

sguilhen mentioned this pull request Sep 19, 2024

Action expired error occurs when accessing regular registration page … #33065

Closed

sguilhen commented Sep 19, 2024

View reviewed changes

keycloak-github-bot bot added the flaky-test label Sep 19, 2024

This was referenced Sep 19, 2024

Flaky test: org.keycloak.testsuite.webauthn.WebAuthnRegisterAndLoginTest#registerUserSuccess #32721

Closed

Flaky test: org.keycloak.testsuite.forms.LoginTest#loginAgainWithoutRememberMe #32476

Closed

keycloak-github-bot bot reviewed Sep 19, 2024

View reviewed changes

sguilhen marked this pull request as ready for review September 19, 2024 03:20

sguilhen requested review from a team as code owners September 19, 2024 03:20

keycloak-github-bot bot added team/ui labels Sep 19, 2024

sguilhen requested review from ahus1 and jonkoops September 19, 2024 03:21

vramik approved these changes Sep 19, 2024

View reviewed changes

edewit previously approved these changes Sep 19, 2024

View reviewed changes

keycloak-github-bot bot reviewed Sep 19, 2024

View reviewed changes

jonkoops previously approved these changes Sep 19, 2024

View reviewed changes

sguilhen dismissed stale reviews from jonkoops and edewit via d529329 September 19, 2024 13:51

sguilhen requested review from a team as code owners September 19, 2024 13:51

keycloak-github-bot bot added team/cloud-native team/core-clients labels Sep 19, 2024

mhajas previously approved these changes Sep 19, 2024

View reviewed changes

keycloak-github-bot bot reviewed Sep 19, 2024

View reviewed changes

Disable remote operator tests

8bebab6

Signed-off-by: Jon Koops <[email protected]>

jonkoops dismissed stale reviews from mhajas and themself via 8bebab6 September 19, 2024 15:45

jonkoops disabled auto-merge September 19, 2024 15:46

jonkoops mentioned this pull request Sep 19, 2024

Fix broken remote tests for operator #33110

Closed

jonkoops enabled auto-merge (squash) September 19, 2024 15:52

jonkoops requested review from edewit, jonkoops, mhajas and vramik September 19, 2024 15:52

jonkoops approved these changes Sep 19, 2024

View reviewed changes

vramik approved these changes Sep 19, 2024

View reviewed changes

vramik mentioned this pull request Sep 19, 2024

Update authentication_test.spec.ts to take Organization related authentication steps into account #33077

Open

mhajas approved these changes Sep 19, 2024

View reviewed changes

jonkoops merged commit 42cde0c into keycloak:main Sep 19, 2024

This was referenced Oct 4, 2024

Backport: Fix various issues holding up CI (24) #33561

Merged

Backport: Fix various issues holding up CI (22) #33562

Merged

sguilhen deleted the 33064-registration-error branch October 25, 2024 14:38

Action expired error occurs when accessing regular registration page … #33086

Action expired error occurs when accessing regular registration page … #33086

Uh oh!

Conversation

sguilhen commented Sep 19, 2024

Uh oh!

sguilhen Sep 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonkoops Sep 19, 2024

Choose a reason for hiding this comment

Uh oh!

vramik Sep 19, 2024

Choose a reason for hiding this comment

Uh oh!

keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

Uh oh!

keycloak-github-bot bot commented Sep 19, 2024

Unreported flaky test detected

org.keycloak.testsuite.webauthn.WebAuthnIdlessTest#testWebAuthnIDLessLogin

org.keycloak.testsuite.webauthn.registration.passwordless.PwdLessOtherSettingsTest#defaultValues

Uh oh!

keycloak-github-bot bot commented Sep 19, 2024

Unreported flaky test detected

org.keycloak.testsuite.webauthn.WebAuthnIdlessTest#testWebAuthnIDLessLogin

org.keycloak.testsuite.webauthn.registration.passwordless.PwdLessOtherSettingsTest#defaultValues

Uh oh!

keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

Uh oh!

keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

Uh oh!

keycloak-github-bot bot commented Sep 19, 2024

Unreported flaky test detected

org.keycloak.testsuite.webauthn.WebAuthnIdlessTest#testWebAuthnIDLessLogin

org.keycloak.testsuite.webauthn.registration.passwordless.PwdLessOtherSettingsTest#defaultValues

Uh oh!

mhajas left a comment

Choose a reason for hiding this comment

Uh oh!

keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

Uh oh!

keycloak-github-bot bot commented Sep 19, 2024

Unreported flaky test detected

org.keycloak.testsuite.forms.LevelOfAssuranceFlowTest#testWithOTPAndRecoveryCodesAtLevel2

Uh oh!

vramik left a comment

Choose a reason for hiding this comment

Uh oh!

mhajas left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sguilhen Sep 19, 2024 •

edited

Loading