fix: adds additional info / warnings to hostname v2 #33261

shawkins · 2024-09-25T01:15:48Z

closes: keycloak#24815 Signed-off-by: Steve Hawkins <[email protected]>

keycloak-github-bot

Unreported flaky test detected, please review

keycloak-github-bot · 2024-09-25T02:15:04Z

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.LevelOfAssuranceFlowTest#testWithOTPAndRecoveryCodesAtLevel2

Keycloak CI - Forms IT (chrome)

org.openqa.selenium.ElementClickInterceptedException: 
element click intercepted: Element <input type="submit" class="pf-v5-c-button pf-v5-c-button pf-m-primary btn-lg" id="saveRecoveryAuthnCodesBtn" value="Complete setup" disabled=""> is not clickable at point (1769, 1393). Other element would receive the click: <form action="https://localhost:8543/auth/realms/test/login-actions/required-action?session_code=Of0k0Mvtt_GihQGz2yDLpvf6Uv_5bMW1P4F67EtzBj8&amp;execution=CONFIGURE_RECOVERY_AUTHN_CODES&amp;client_id=test-app&amp;tab_id=2Lhti8gUctQ&amp;client_data=eyJydSI6Imh0dHBzOi8vbG9jYWxob3N0Ojg1NDMvYXV0aC9yZWFsbXMvbWFzdGVyL2FwcC9hdXRoIiwicnQiOiJjb2RlIiwic3QiOiJkNTU3ODg0Yy01YzdkLTQyMjItYjE3NC0yYTYzYjQyYjlmOTcifQ" class="pf-v5-c-form__group" id="kc-recovery-codes-settings-form" method="post">...</form>
  (Session info: chrome=128.0.6613.137)
Build info: version: '4.21.0', revision: '79ed462ef4'
System info: os.name: 'Linux', os.arch: 'amd64', os.version: '6.8.0-1014-azure', java.version: '21.0.4'
...

Report flaky test

Signed-off-by: Steve Hawkins <[email protected]>

shawkins · 2024-09-25T13:28:47Z

Added some refinements to #33209 on this pr as well - it can be done as a separate one if desired.

keycloak-github-bot

Unreported flaky test detected, please review

keycloak-github-bot · 2024-09-25T14:19:03Z

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.webauthn.registration.PolicyJsInjectionTest#requireResidentKey

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected RegisterPage but was Sign in to test (https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?response_type=code&client_id=test-app&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Fmaster%2Fapp%2Fauth&state=0dd0e9e5-18d0-49a9-a3aa-61365280c64c&scope=openid)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

org.keycloak.testsuite.webauthn.registration.ResidentKeyRegisterTest#residentKeyNotRequiredNoRK

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected LoginPage but was AUTH_RESPONSE (https://localhost:8543/auth/realms/master/app/auth?state=7825c07a-17c6-422e-812b-b2f5c364ba70&session_state=ab1a29d5-145d-4a8e-b41d-7dbe556af266&iss=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Ftest&code=88976b63-3fda-46b0-81fd-28e2a1020e75.ab1a29d5-145d-4a8e-b41d-7dbe556af266.dd631abe-72dc-46fb-811d-7585f47be708)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at org.keycloak.testsuite.pages.LoginPage.open(LoginPage.java:262)
...

Report flaky test

org.keycloak.testsuite.webauthn.registration.passwordless.PwdLessResidentKeyRegTest#residentKeyNotRequiredPresent

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected RegisterPage but was Sign in to test (https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?response_type=code&client_id=test-app&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Fmaster%2Fapp%2Fauth&state=ea9ab455-c5db-4524-8644-417fdb42ba4d&scope=openid)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

Signed-off-by: Steve Hawkins <[email protected]>

vmuzikar · 2024-09-27T14:12:55Z

services/src/main/java/org/keycloak/url/HostnameV2ProviderFactory.java

        }
-
+
+        List<String> inUse = REMOVED_OPTIONS.stream().filter(s -> config.get(s) != null).toList();


@shawkins I believe this won't work as the config provider here has a scope that only contains options starting with kc.spi-hostname-v2-. The old options had a prefix of kc.spi-hostname-default-.

Since we don't have access to all config options through the SmallRye Config here, we have move it somewhere to quarkus module I'm afraid.

Since we don't have access to all config options through the SmallRye Config here, we have move it somewhere to quarkus module I'm afraid.

Right, forgot about the spi mapping. I'll move it.

Signed-off-by: Steve Hawkins <[email protected]>

vmuzikar

LGTM, thanks!

mabartos

@shawkins Just some typos. I don't want to block this PR due to these nitpicks, so merge it manually if necessary.

.../main/java/org/keycloak/quarkus/runtime/configuration/mappers/HostnameV2PropertyMappers.java

...kus/runtime/src/main/java/org/keycloak/quarkus/runtime/cli/command/AbstractStartCommand.java

docs/guides/server/hostname.adoc

…figuration/mappers/HostnameV2PropertyMappers.java Co-authored-by: Martin Bartoš <[email protected]> Signed-off-by: Steven Hawkins <[email protected]>

docs/guides/server/hostname.adoc

Signed-off-by: Steven Hawkins <[email protected]>

mabartos

@shawkins Looks better now, thanks!

cc @vmuzikar - just to be aware of the latest changes

keycloak-github-bot

Unreported flaky test detected, please review

keycloak-github-bot · 2024-09-27T17:37:48Z

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.webauthn.WebAuthnPropertyTest#requiredActionRegistration

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected LoginPage but was AUTH_RESPONSE (https://localhost:8543/auth/realms/master/app/auth?state=7b8298fb-17a3-45ef-9a73-6f26763dbf2f&session_state=97d0cfc5-1298-478c-aa3b-de4c4dc11bb4&iss=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Ftest&code=1e21121d-57b7-4218-bbe1-8d6e98a8c9eb.97d0cfc5-1298-478c-aa3b-de4c4dc11bb4.8d46e7e3-f549-42fa-9f80-acac5e63c030)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at org.keycloak.testsuite.pages.LoginPage.open(LoginPage.java:262)
...

Report flaky test

keycloak-github-bot

Unreported flaky test detected, please review

keycloak-github-bot · 2024-09-27T22:46:38Z

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.webauthn.WebAuthnPropertyTest#requiredActionRegistration

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected LoginPage but was AUTH_RESPONSE (https://localhost:8543/auth/realms/master/app/auth?state=7b8298fb-17a3-45ef-9a73-6f26763dbf2f&session_state=97d0cfc5-1298-478c-aa3b-de4c4dc11bb4&iss=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Ftest&code=1e21121d-57b7-4218-bbe1-8d6e98a8c9eb.97d0cfc5-1298-478c-aa3b-de4c4dc11bb4.8d46e7e3-f549-42fa-9f80-acac5e63c030)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at org.keycloak.testsuite.pages.LoginPage.open(LoginPage.java:262)
...

Report flaky test

fix: adds additional info / warnings to hostname v2

60e03b4

closes: keycloak#24815 Signed-off-by: Steve Hawkins <[email protected]>

shawkins requested a review from a team as a code owner September 25, 2024 01:15

shawkins mentioned this pull request Sep 25, 2024

Hostname config check on welcome page #24815

Closed

keycloak-github-bot bot added the flaky-test label Sep 25, 2024

This was referenced Sep 25, 2024

Flaky test: org.keycloak.testsuite.webauthn.registration.passwordless.PwdLessOtherSettingsTest#defaultValues #33183

Closed

Flaky test: org.keycloak.testsuite.webauthn.registration.passwordless.PwdLessPubKeySignRegTest#publicKeySignaturesEmpty #32634

Closed

keycloak-github-bot bot reviewed Sep 25, 2024

View reviewed changes

refining the proxy-headers language from keycloak#33209

882cb41

Signed-off-by: Steve Hawkins <[email protected]>

shawkins requested a review from a team as a code owner September 25, 2024 13:16

keycloak-github-bot bot added the team/cloud-native label Sep 25, 2024

Pepo48 previously approved these changes Sep 25, 2024

View reviewed changes

keycloak-github-bot bot mentioned this pull request Sep 25, 2024

Flaky test: org.keycloak.testsuite.forms.BrowserButtonsTest#appInitiatedRegistrationWithBackButton #32676

Closed

keycloak-github-bot bot reviewed Sep 25, 2024

View reviewed changes

adding hostname-strict-https

cf486d8

Signed-off-by: Steve Hawkins <[email protected]>

shawkins dismissed Pepo48’s stale review via cf486d8 September 25, 2024 14:40

shawkins mentioned this pull request Sep 26, 2024

Support for unmatching context-paths with reverse proxys #16348

Closed

vmuzikar requested changes Sep 27, 2024

View reviewed changes

moving removed property check to the quarkus side

e0ddbf3

Signed-off-by: Steve Hawkins <[email protected]>

vmuzikar previously approved these changes Sep 27, 2024

View reviewed changes

vmuzikar enabled auto-merge (squash) September 27, 2024 15:13

mabartos reviewed Sep 27, 2024

View reviewed changes

mabartos disabled auto-merge September 27, 2024 15:23

This was referenced Sep 27, 2024

Flaky test: org.keycloak.testsuite.webauthn.WebAuthnIdlessTest#testWebAuthnIDLessWithNonResidentCredentialLogin #32939

Closed

Flaky test: org.keycloak.testsuite.forms.LoginTest#loginAgainWithoutRememberMe #32476

Closed

Update quarkus/runtime/src/main/java/org/keycloak/quarkus/runtime/con…

53b5635

…figuration/mappers/HostnameV2PropertyMappers.java Co-authored-by: Martin Bartoš <[email protected]> Signed-off-by: Steven Hawkins <[email protected]>

shawkins dismissed vmuzikar’s stale review via 53b5635 September 27, 2024 16:19

shawkins commented Sep 27, 2024

View reviewed changes

docs/guides/server/hostname.adoc Outdated Show resolved Hide resolved

Update docs/guides/server/hostname.adoc

8c29b35

Signed-off-by: Steven Hawkins <[email protected]>

mabartos approved these changes Sep 27, 2024

View reviewed changes

mabartos enabled auto-merge (squash) September 27, 2024 16:33

keycloak-github-bot bot reviewed Sep 27, 2024

View reviewed changes

vmuzikar approved these changes Sep 27, 2024

View reviewed changes

keycloak-github-bot bot reviewed Sep 27, 2024

View reviewed changes

mabartos merged commit f1a7a48 into keycloak:main Sep 28, 2024

shawkins mentioned this pull request Sep 30, 2024

Admin UI impossible #33414

Closed

2 tasks

		}


		List<String> inUse = REMOVED_OPTIONS.stream().filter(s -> config.get(s) != null).toList();

fix: adds additional info / warnings to hostname v2 #33261

fix: adds additional info / warnings to hostname v2 #33261

Uh oh!

Conversation

shawkins commented Sep 25, 2024

Uh oh!

keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

Uh oh!

keycloak-github-bot bot commented Sep 25, 2024

Unreported flaky test detected

org.keycloak.testsuite.forms.LevelOfAssuranceFlowTest#testWithOTPAndRecoveryCodesAtLevel2

Uh oh!

shawkins commented Sep 25, 2024

Uh oh!

keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

Uh oh!

keycloak-github-bot bot commented Sep 25, 2024

Unreported flaky test detected

org.keycloak.testsuite.webauthn.registration.PolicyJsInjectionTest#requireResidentKey

org.keycloak.testsuite.webauthn.registration.ResidentKeyRegisterTest#residentKeyNotRequiredNoRK

org.keycloak.testsuite.webauthn.registration.passwordless.PwdLessResidentKeyRegTest#residentKeyNotRequiredPresent

Uh oh!

vmuzikar Sep 27, 2024

Choose a reason for hiding this comment

Uh oh!

shawkins Sep 27, 2024

Choose a reason for hiding this comment

Uh oh!

vmuzikar left a comment

Choose a reason for hiding this comment

Uh oh!

mabartos left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mabartos left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

Uh oh!

keycloak-github-bot bot commented Sep 27, 2024

Unreported flaky test detected

org.keycloak.testsuite.webauthn.WebAuthnPropertyTest#requiredActionRegistration

Uh oh!

keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

Uh oh!

keycloak-github-bot bot commented Sep 27, 2024

Unreported flaky test detected

org.keycloak.testsuite.webauthn.WebAuthnPropertyTest#requiredActionRegistration

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mabartos left a comment •

edited

Loading

mabartos left a comment •

edited

Loading