Thanks to visit codestin.com
Credit goes to github.com

Skip to content

BACKPORT: added possible override #34479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
agagancarczyk merged 1 commit into from
Oct 30, 2024
Merged

BACKPORT: added possible override #34479

agagancarczyk merged 1 commit into from
Oct 30, 2024

Conversation

@edewit
Copy link
Contributor

@edewit edewit commented Oct 30, 2024

fixes: #33640
backport: #33673

Signed-off-by: Erik Jan de Wit [email protected]
(cherry picked from commit c5d26bd)

@edewit
added possible override
ba26360 
fixes: keycloak#33640

Signed-off-by: Erik Jan de Wit <[email protected]>
(cherry picked from commit c5d26bd)
@edewit edewit requested review from a team as code owners October 30, 2024 08:02
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Oct 30, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

keycloak-github-bot bot commented Oct 30, 2024

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.LoginTest#loginAgainWithoutRememberMe

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at org.keycloak.testsuite.forms.LoginTest.loginAgainWithoutRememberMe(LoginTest.java:693)
...

Report flaky test

@edewit edewit self-assigned this Oct 30, 2024
@agagancarczyk agagancarczyk merged commit 58c7957 into keycloak:release/26.0 Oct 30, 2024
@edewit edewit mentioned this pull request Nov 19, 2024
Closed
@edewit edewit mentioned this pull request Dec 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

@agagancarczyk agagancarczyk agagancarczyk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@edewit edewit

Labels

flaky-test team/ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@edewit @agagancarczyk