Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fine grained admin permissions feature V2 #34568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ahus1 merged 2 commits into from
Nov 7, 2024
Merged

Fine grained admin permissions feature V2 #34568

ahus1 merged 2 commits into from
Nov 7, 2024

Conversation

@vramik
Copy link
Contributor

@vramik vramik commented Nov 1, 2024 •
edited
Loading

Closes #34563
Closes #34635

@keycloak-github-bot
Copy link

keycloak-github-bot bot commented Nov 1, 2024

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.broker.KcOidcBrokerTest#testPostBrokerLoginFlowWithOTP_bruteForceEnabled

Keycloak CI - Java Distribution IT (windows-latest - temurin - 17)

java.lang.AssertionError: User should be disabled by brute force.
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.broker.AbstractAdvancedBrokerTest.testPostBrokerLoginFlowWithOTP_bruteForceEnabled(AbstractAdvancedBrokerTest.java:579)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
...

Report flaky test

keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Nov 1, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@vramik vramik force-pushed the 34563-FGAP-feature-v2 branch 3 times, most recently from 88adaca to 80812c6 Compare November 1, 2024 14:54
@keycloak-github-bot keycloak-github-bot bot mentioned this pull request Nov 1, 2024
Closed
@vramik vramik marked this pull request as ready for review November 4, 2024 09:23
@vramik vramik requested review from a team as code owners November 4, 2024 09:23
@vramik vramik requested a review from pedroigor November 4, 2024 11:37
pedroigor
pedroigor reviewed Nov 4, 2024
View reviewed changes
@vramik vramik force-pushed the 34563-FGAP-feature-v2 branch from 80812c6 to 5fbe0f6 Compare November 4, 2024 15:24
@keycloak-github-bot keycloak-github-bot bot mentioned this pull request Nov 4, 2024
Closed
@vramik vramik force-pushed the 34563-FGAP-feature-v2 branch from 53a1b80 to bfdc41d Compare November 4, 2024 18:45
@keycloak-github-bot
Copy link

keycloak-github-bot bot commented Nov 4, 2024

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.BrowserFlowTest#testLoginWithWithNoOTPCredential

Keycloak CI - Forms IT (chrome)

org.openqa.selenium.TimeoutException: 
timeout: Timed out receiving message from renderer: 10.000
  (Session info: chrome=130.0.6723.58)
Build info: version: '4.25.0', revision: '8a8aea2337'
System info: os.name: 'Linux', os.arch: 'amd64', os.version: '6.5.0-1025-azure', java.version: '21.0.4'
...

Report flaky test

org.keycloak.testsuite.forms.RegisterTest#registerUpperCaseEmailAsUsername

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError: Expected LoginPage but was localhost (https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?response_type=code&client_id=test-app&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Fmaster%2Fapp%2Fauth&state=26227f31-0e1b-4e93-88ba-2ea2ea614291&scope=openid)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at org.keycloak.testsuite.pages.LoginPage.open(LoginPage.java:253)
...

Report flaky test

keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Nov 4, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@vramik vramik requested a review from pedroigor November 5, 2024 10:46
@vramik vramik removed the request for review from pedroigor November 7, 2024 08:12
ahus1
ahus1 approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on previous reviews.

@ahus1 ahus1 merged commit a2ba3c8 into keycloak:main Nov 7, 2024
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedroigor pedroigor pedroigor left review comments

@ahus1 ahus1 ahus1 approved these changes

+2 more reviewers

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

@sguilhen sguilhen sguilhen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test team/cloud-native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature in higher version takes precedence even if it has lower type order [FGAP] Add feature V2

4 participants

@vramik @sguilhen @pedroigor @ahus1