fix: persist build time spi options #34157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c23abe6 to
8be026e
Compare
Contributor
|
@shawkins What's the status of this PR? |
Contributor
Author
Needs the other pr merged first. |
closes: keycloak#33902 Signed-off-by: Steve Hawkins <[email protected]>
8be026e to
5cff253
Compare
Contributor
Author
|
Ready now. |
vmuzikar
reviewed
Oct 23, 2024
...arquillian/tests/base/src/main/java/org/keycloak/testsuite/client/KeycloakTestingClient.java
Show resolved
Hide resolved
Contributor
|
@shawkins Can you please create the backport? |
shawkins
added a commit
to shawkins/keycloak
that referenced
this pull request
Oct 23, 2024
closes: keycloak#33902 Signed-off-by: Steve Hawkins <[email protected]> (cherry picked from commit b2ccde2)
Contributor
Author
shawkins
added a commit
to shawkins/keycloak
that referenced
this pull request
Oct 23, 2024
closes: keycloak#33902 Signed-off-by: Steve Hawkins <[email protected]> (cherry picked from commit b2ccde2)
vmuzikar
pushed a commit
that referenced
this pull request
Oct 23, 2024
closes: #33902 Signed-off-by: Steve Hawkins <[email protected]> (cherry picked from commit b2ccde2)
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #33902
This should test cleanly after #34156 and a test tweak is incorporated.
There will be a later follow-up to enable the arquillian tests to just use auto-builds.- auto-builds seem to be sufficient.