OTEL: Fix #podNamePropagation test for Operator #35769
Conversation
operator/src/test/java/org/keycloak/operator/testsuite/integration/TracingDeploymentTest.java
Outdated
Show resolved
Hide resolved
4b07552 to
50523e9
Compare
Problem SummaryAs we use optimized custom Keycloak image when testing Operator, some problems occurred due to the build time options manner. In order to properly start distribution with Tracing enabled, we need to have enabled However, as the Operator uses an optimized image, no augmentation was done and we faced quite weird behavior due to it. It was a series of unhappy coincidences:
In this PR, probes are enabled and we will wait for the proper server startup with the tracing capabilities to verify everything works as expected. We unmarked the image as optimized, so the reaugmentation is happening. It should solve the problem and the issue should not occur again. We can keep an eye on it for some time, but I believe it's gonna be ok. |
operator/src/test/java/org/keycloak/operator/testsuite/integration/TracingDeploymentTest.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @Test | ||
| public void podNamePropagation() { |
There was a problem hiding this comment.
Possibly we don't even need to move it to a separate test class, WDYT?
There was a problem hiding this comment.
I'd like to move here also the test case for Keycloak Tracing CR to have it separated. Does it work for you?
There was a problem hiding this comment.
Sure, if we move the other tracing test here, that seems good. Point is to keep them in a single place.
There was a problem hiding this comment.
Do you want move the other test here as well?
There was a problem hiding this comment.
I think it should be done in a separate PR to keep some sort of atomicity.
There was a problem hiding this comment.
Ok, works for me either way, don't want to block this PR on this.
My reasoning to suggest moving the other OTEL test (testTracingSpec) in this PR was that we're also moving podNamePropagation to a new test class here, so felt natural to me to move both at the same time. But it's not a blocker for me.
50523e9 to
58fba53
Compare
Fixes keycloak#32490 Signed-off-by: Martin Bartoš <[email protected]>
58fba53 to
f9e608a
Compare
|
Should be ok now. |
| } | ||
|
|
||
| @Test | ||
| public void podNamePropagation() { |
There was a problem hiding this comment.
Ok, works for me either way, don't want to block this PR on this.
My reasoning to suggest moving the other OTEL test (testTracingSpec) in this PR was that we're also moving podNamePropagation to a new test class here, so felt natural to me to move both at the same time. But it's not a blocker for me.
As the custom Keycloak image is used when testing the Operator, it should be unmarked as optimized to be properly set up.
Draft PR for now as some tweaks to the main will be added. This should be ready for backport.