Add new error type in authz client and handle properly missing resources errors #36561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@ebondu Could you please add DCO to the commit message? See https://github.com/keycloak/keycloak/blob/main/CONTRIBUTING.md#developers-certificate-of-origin for the details (usually the |
…ces errors to enable policy enforcer resource cache eviction/update. Closes keycloak#36560 Signed-off-by: Emilien Bondu <[email protected]>
d778557 to
78e45f1
Compare
mposolda
approved these changes
Jan 20, 2025
Contributor
mposolda
left a comment
There was a problem hiding this comment.
@ebondu Thanks!
If you want to have this available sooner in keycloak-client, it would be welcome to backport this also to release/26.1 branch . You can possibly use this script in that case for creating backport PR: https://github.com/keycloak/keycloak/blob/main/.github/scripts/pr-backport.sh .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By throwing a more specific error, the policy enforcer will be able to handle properly this situation and the evict/update his own resource cache.
See the associated policy enforcer PR
Closes #36560