Grant Type condition for client policies #37665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes keycloak#37124 Signed-off-by: Giuseppe Graziano <[email protected]>
mposolda
reviewed
Feb 27, 2025
services/src/main/java/org/keycloak/services/clientpolicy/condition/GrantTypeCondition.java
Outdated
Show resolved
Hide resolved
...es/src/main/java/org/keycloak/services/clientpolicy/condition/GrantTypeConditionFactory.java
Outdated
Show resolved
Hide resolved
...se/src/test/java/org/keycloak/testsuite/oauth/tokenexchange/StandardTokenExchangeV2Test.java
Outdated
Show resolved
Hide resolved
Closes keycloak#37124 Signed-off-by: Giuseppe Graziano <[email protected]>
Contributor
Author
|
@douglaspalmer @mposolda Thanks for the review! Applied the suggestions in a separate commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #37124
Added a Condition in client policies to check when a grant type is used.
The
DEFAULT_GRANT_TYPES_SUPPORTEDinGrantTypeConditionFactoryare not resolved as inOIDCWellKnownProvider.getGrantTypesSupported()due to the absence of theKeycloakSession.Added tests and small documentation.