Polishing token exchange with offline tokens #37708
Merged
+150
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes keycloak#37116 Signed-off-by: mposolda <[email protected]>
graziang
approved these changes
Feb 28, 2025
Contributor
graziang
left a comment
There was a problem hiding this comment.
@mposolda Thanks, LGTM. Changes in this PR should be considered in the revocation process. It doesn't seem possible to revoke session created through token exchange when revoking the original access token but maybe a solution can be found.
Contributor
Author
|
@graziang Thanks! Added some ideas to #37120 , however not sure if we can support them without sacrificing performance. Especially in the case when new userSession is created by the token-exchange, it can have performance impact... Not sure whether to not support this and rather document that "revocation chain" won't be supported in case that new user-session needed to be created ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #37116
Using option (2) of what discussed in the comments in Polish token-exchange when refresh-token requested with the offline access #37116 . So token-exchange allowed when triggered without
scope=offline_accessand when initialsubject_tokenwas linked to offline session. In this case, new "online" user session is createdAlso added cleanup of "tombstone" sessions in this PR. For example if token-exchange request fails due the fact that
scope=offline_accesswas used or due the consents, it was possible that clientSession or userSession, which was possibly created in this request, was still kept. In this PR, I've did cleanup of such sessions