Ensure a sufficient virtual threads pool #37197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afff2db to
c457ef6
Compare
Contributor
Author
pruivo
reviewed
Feb 10, 2025
| This reduces the memory usage and removes the need to configure thread pool sizes. | ||
| Therefore, the use of OpenJDK 21 is recommended. | ||
|
|
||
| === JGroups communications |
Member
There was a problem hiding this comment.
this seems duplicated from line 15.
Contributor
Author
There was a problem hiding this comment.
Thank you for spotting this one, fixed. Please re-review.
c457ef6 to
c692dcb
Compare
Closes keycloak#37162 Signed-off-by: Alexander Schwartz <[email protected]>
c692dcb to
6bf562d
Compare
pruivo
approved these changes
Feb 10, 2025
mabartos
approved these changes
Feb 10, 2025
Contributor
mabartos
left a comment
There was a problem hiding this comment.
Looks good from the Quarkus code side.
mhajas
approved these changes
Feb 10, 2025
Contributor
mhajas
left a comment
There was a problem hiding this comment.
Approving based on reviews from others
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #37162