Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ahus1
Copy link
Contributor

@ahus1 ahus1 commented Feb 12, 2025

Closes #37285

My local test didn't show pinned threads with the pure JGroups communication. Just org.infinispan.topology.ClusterCacheStatus seems to have one pinned placed when a node leaves.

It seems that the ISPN 15.0.x branch was already updated in infinispan/infinispan#14021 so it should arrive soon with a regular ISPN release.

@ahus1 ahus1 self-assigned this Feb 12, 2025
@ahus1 ahus1 marked this pull request as ready for review February 12, 2025 10:21
@ahus1 ahus1 requested a review from a team as a code owner February 12, 2025 10:21
@ahus1 ahus1 requested a review from pruivo February 12, 2025 10:22
@ahus1
Copy link
Contributor Author

ahus1 commented Feb 12, 2025

@pruivo - please review when you have the time. I might be tempted to backport it to KC 26.1.

Copy link
Member

@pruivo pruivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ahus1
Copy link
Contributor Author

ahus1 commented Feb 12, 2025

@mhajas - can you please approve and merge based on Pedro's review? Thanks!

@ahus1 ahus1 requested a review from mhajas February 12, 2025 10:42
Copy link
Contributor

@mhajas mhajas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ahus1, I am merging. Is there an issue to revert this when Infinispan version is udpated?

@mhajas mhajas merged commit 5a8c014 into keycloak:main Feb 12, 2025
76 checks passed
@ahus1
Copy link
Contributor Author

ahus1 commented Feb 12, 2025

Is there an issue to revert this when Infinispan version is udpated?

I placed this very close to the ISPN version number in the POM, so I would hope that this isn't needed.

ahus1 added a commit to ahus1/keycloak that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to latest JGroups patch version

3 participants