Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Refactored Proof into a base interface with JwtProof and LdpVpProof as concrete implementations #39466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mposolda merged 1 commit into from
May 13, 2025
Merged

Refactored Proof into a base interface with JwtProof and LdpVpProof as concrete implementations #39466

mposolda merged 1 commit into from
May 13, 2025

Conversation

@forkimenjeckayang
Copy link
Contributor

@forkimenjeckayang forkimenjeckayang commented May 5, 2025 •
edited
Loading

This PR refactors the Proof class to serve as a base interface that new proof types implement, aligning with the OID4VCI spec’s support for mutually exclusive proof types. Key changes include:

  • Refactored Proof into a base interface with JwtProof and LdpVpProof as implementations to handle specific proof types, resolving type mismatches.
  • Updated tests to reflect the new structure and ensure compatibility with the changes.
  • Drop support and references to the CWT proof type

Closes #31363
Closes #39271

@forkimenjeckayang
Refactored Proof into a base interface with JwtProof and LdpVpProof i…
aec61cd 
…mplementations to support mutually exclusive proof types per OID4VCI spec, and removed CwtProof support as per Draft 14.

Closes keycloak#31363

Signed-off-by: forkimenjeckayang <[email protected]>
@forkimenjeckayang forkimenjeckayang requested review from a team as code owners May 5, 2025 15:39
@forkimenjeckayang forkimenjeckayang mentioned this pull request May 5, 2025
Closed
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed May 5, 2025
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

keycloak-github-bot bot commented May 5, 2025

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.RegisterTest#registerUserSuccess_emailAsUsername

Keycloak CI - Forms IT (chrome)

java.lang.IllegalArgumentException: No enum constant org.keycloak.testsuite.pages.AppPage.RequestType.localhost
	at java.base/java.lang.Enum.valueOf(Enum.java:293)
	at org.keycloak.testsuite.pages.AppPage$RequestType.valueOf(AppPage.java:57)
	at org.keycloak.testsuite.pages.AppPage.getRequestType(AppPage.java:46)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

@mposolda mposolda self-assigned this May 6, 2025
@mposolda mposolda added the area/oid4vc Issue related to OpenID for Verifiable Credentials label May 7, 2025
Captain-P-Goldfish
Captain-P-Goldfish approved these changes May 8, 2025
View reviewed changes
Copy link
Contributor

@Captain-P-Goldfish Captain-P-Goldfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
But I just noticed that we do not seem to have a ticket for handling the proofs-attribute. I just created one: #39554

mposolda
mposolda approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor

@mposolda mposolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@forkimenjeckayang @IngridPuppet @Captain-P-Goldfish Thanks for the PR and review!

@mposolda mposolda merged commit 910513f into keycloak:main May 13, 2025
76 checks passed
robson90 pushed a commit to robson90/keycloak that referenced this pull request Jul 9, 2025
@forkimenjeckayang @robson90
Refactored Proof into a base interface with JwtProof and LdpVpProof i…
ec16772 
…mplementations to support mutually exclusive proof types per OID4VCI spec, and removed CwtProof support as per Draft 14. (keycloak#39466)

Closes keycloak#31363
Closes keycloak#39271

Signed-off-by: forkimenjeckayang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mposolda mposolda mposolda approved these changes

+3 more reviewers

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

@Captain-P-Goldfish Captain-P-Goldfish Captain-P-Goldfish approved these changes

@IngridPuppet IngridPuppet IngridPuppet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mposolda mposolda

Labels

area/oid4vc Issue related to OpenID for Verifiable Credentials flaky-test team/cloud-native team/core-clients team/core-iam

Projects

None yet

Milestone

No milestone

4 participants

@forkimenjeckayang @mposolda @Captain-P-Goldfish @IngridPuppet