added junit results xml so we can use existing flaky test detection #39701
Conversation
37d264b to
2bbc17f
Compare
fixes: keycloak#39700 Signed-off-by: Erik Jan de Wit <[email protected]>
Signed-off-by: Erik Jan de Wit <[email protected]>
stianst
left a comment
There was a problem hiding this comment.
It's been a while, but if I remember correctly the way the flaky test works for Java:
- Surefire generates a
TEST-???.xmlfile for each test class that runs. If there are flaky tests there will be a<flakyFailureor<flakyErrorin the file. upload-flaky-testthen looks for these, and if any are found uploads the artifacts to the GH run- The bot looks for runs that have completed and have
flaky-tests-*artifacts uploaded, and for those that have it will create or update GH issues accordingly
It seems in this PR you are removing the part that is looking for the test reports with flaky entries, which would then stop making this work for Java tests.
For js-ci.yml it's not using this action, but instead uploading test results, which probably wouldn't be in the needed format.
Could you elaborate a bit on the changes in this PR? It doesn't make all that much sense to me.
|
Right I've added surefire xml results to the playwright tests, but they don't have the |
fixes: #39700
Signed-off-by: Erik Jan de Wit [email protected]