Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Verification of external OIDC token by introspection-endpoint. Adding… #40856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mposolda merged 1 commit into from
Jul 3, 2025
Merged

Verification of external OIDC token by introspection-endpoint. Adding… #40856

mposolda merged 1 commit into from
Jul 3, 2025

Conversation

@mposolda
Copy link
Contributor

@mposolda mposolda commented Jul 2, 2025

… ExternalInternalTokenExchangeV2Test

closes #40167
closes #40198

@mposolda mposolda self-assigned this Jul 2, 2025
@mposolda mposolda marked this pull request as ready for review July 2, 2025 12:52
@mposolda mposolda requested review from a team as code owners July 2, 2025 12:52
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Jul 2, 2025
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

keycloak-github-bot bot commented Jul 2, 2025

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest#testPostBadAssertionSignature

Keycloak CI - Base IT

org.openqa.selenium.JavascriptException: 
TypeError: document.documentElement is null
Build info: version: '4.28.1', revision: '73f5ad48a2'
System info: os.name: 'Linux', os.arch: 'amd64', os.version: '6.11.0-1015-azure', java.version: '21.0.7'
Driver info: org.openqa.selenium.firefox.FirefoxDriver
...

Report flaky test

@mposolda
Verification of external OIDC token by introspection-endpoint. Adding…
f7cfbfa 
… ExternalInternalTokenExchangeV2Test

closes keycloak#40167
closes keycloak#40198

Signed-off-by: mposolda <[email protected]>
@mposolda mposolda requested a review from pedroigor July 3, 2025 06:55
graziang
graziang approved these changes Jul 3, 2025
View reviewed changes
Copy link
Contributor

@graziang graziang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mposolda thanks!

rmartinc
rmartinc approved these changes Jul 3, 2025
View reviewed changes
Copy link
Contributor

@rmartinc rmartinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mposolda LGTM!

@mposolda mposolda merged commit c52edc8 into keycloak:main Jul 3, 2025
84 of 86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedroigor pedroigor pedroigor approved these changes

+4 more reviewers

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

@jonkoops jonkoops jonkoops approved these changes

@graziang graziang graziang approved these changes

@rmartinc rmartinc rmartinc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mposolda mposolda

Labels

flaky-test team/cloud-native team/core-clients team/core-iam team/ui

Projects

None yet

Milestone

No milestone

5 participants

@mposolda @jonkoops @pedroigor @graziang @rmartinc