-
Couldn't load subscription status.
- Fork 7.7k
Add configurable HTTP retry mechanism for OCSP validation #42535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chance-coleman
wants to merge
10
commits into
keycloak:main
Choose a base branch
from
chance-coleman:retry-httpclient-implementation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
6d60399
Add OCSP retry configuration and HTTP retry mechanism
chance-coleman 021fee7
refactor retriable client to use cached cclient to be more optimized
chance-coleman fb07239
implement equals override to simplify equality of httpclients
chance-coleman 8a0dfde
Simplify HTTP client retry to server-wide configuration
chance-coleman dc87a7f
Simplify HTTP client retry to single client with server-wide configur…
chance-coleman a17325a
Simplify HTTP client retry to single client with server-wide configur…
chance-coleman 397a50b
address feedback for more documentation and cleanup
chance-coleman 9d1b248
fix whitespace
chance-coleman 6b9eac6
Merge branch 'main' into retry-httpclient-implementation
chance-coleman e202cdf
add doc callout about the danger of not configuring the timeout appro…
chance-coleman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add something around the fact that outgoing request retries should not exceed the timeout for incoming requests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a callout like this:
IMPORTANT: Do not let outgoing retry duration exceed the caller’s timeout. Otherwise, the caller may time out and see an error while {project_name} continues retrying in the background.