ignores unknown json properties in dcr requests #43603
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables ignoring unknown JSON properties on OIDCClientRepresentation and adjusts / extends integration tests accordingly. This is required to adhere to section 2 of RFC 7591 which documents that "the authorization server MUST ignore any client metadata sent by the client that it does not understand". Closes keycloak#14946 Signed-off-by: Remco Jansen <[email protected]>
mposolda
reviewed
Oct 22, 2025
There was a problem hiding this comment.
@remcojansen Thanks for the PR. I've added one inline comment. Can you please check that?
| * @author <a href="mailto:[email protected]">Stian Thorgersen</a> | ||
| */ | ||
| @JsonAutoDetect(fieldVisibility = JsonAutoDetect.Visibility.ANY, getterVisibility = JsonAutoDetect.Visibility.NONE, setterVisibility = JsonAutoDetect.Visibility.NONE) | ||
| @JsonIgnoreProperties(ignoreUnknown = true) |
There was a problem hiding this comment.
Is it possible to instead introduce otherClaims map with @JsonAnyGetter and @JsonAnySetter where the unknown claims will be saved? It might be better, so that custom providers are able to parse unknown fields. WDYT?
See the class JsonWebToken for the inspiration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables ignoring unknown JSON properties on OIDCClientRepresentation and adjusts / extends integration tests accordingly.
This is required to adhere to section 2 of RFC 7591 which documents that "the authorization server MUST ignore any client metadata sent by the client that it does not understand".
Closes #14946