Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Avoid touching the database layer if no changes are necessary for a user #43697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: release/26.0
Choose a base branch
from
Draft

Avoid touching the database layer if no changes are necessary for a user #43697

wants to merge 5 commits into from
+56 −11

Conversation

@ahus1
Copy link
Contributor

@ahus1 ahus1 commented Oct 24, 2025

Closes #43682

ahus1 added 4 commits October 24, 2025 15:02
@ahus1
Avoid touching the database layer if no changes are necessary for a user
e749e76 
Closes keycloak#43682

Signed-off-by: Alexander Schwartz <[email protected]>
@ahus1
Review
6feffbc 
Signed-off-by: Alexander Schwartz <[email protected]>
@ahus1
Revert
585934a 
Signed-off-by: Alexander Schwartz <[email protected]>
@ahus1
Fix compile
c8b15ed 
Signed-off-by: Alexander Schwartz <[email protected]>
@ahus1 ahus1 self-assigned this Oct 24, 2025
@ahus1 ahus1 mentioned this pull request Oct 24, 2025
Open
@ahus1
Fixing the test
2cd601d 
Signed-off-by: Alexander Schwartz <[email protected]>
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Oct 24, 2025
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.broker.KcOidcBrokerTest#testPostBrokerLoginFlowWithOTP_bruteForceEnabled

Keycloak CI - Java Distribution IT (windows-latest - temurin - 17)

java.lang.AssertionError: User should be disabled by brute force.
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.broker.AbstractAdvancedBrokerTest.testPostBrokerLoginFlowWithOTP_bruteForceEnabled(AbstractAdvancedBrokerTest.java:580)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
...

Report flaky test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@ahus1 ahus1

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ahus1