Only add the none verifier when attestation conveyance preference is none#43727
Merged
abstractj merged 1 commit intokeycloak:mainfrom Oct 28, 2025
Merged
Only add the none verifier when attestation conveyance preference is none#43727abstractj merged 1 commit intokeycloak:mainfrom
abstractj merged 1 commit intokeycloak:mainfrom
Conversation
…none Closes keycloak#43723 Signed-off-by: rmartinc <[email protected]>
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.federation.ldap.LDAPProvidersIntegrationTest#updateLDAPUsernameTest |
Contributor
Author
|
@tnorimat I have added you as reviewer. This is the PR for the WebAuthn issue we commented some days ago. Thanks! |
graziang
approved these changes
Oct 27, 2025
tnorimat
approved these changes
Oct 28, 2025
ahus1
approved these changes
Oct 28, 2025
Member
ahus1
left a comment
There was a problem hiding this comment.
Approving based on previous reviews.
This was referenced Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #43723
The PR just assigns the none verifier if none is configured in the current policy (or default/empty). This way we avoid allowing none when the attestation conveyance is direct or indirect. A test is added that changes the policy when the registration page is already ready to be sent.