Ensure the logout endpoint removes the authentication session #43872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes keycloak#43853 Signed-off-by: rmartinc <[email protected]>
Contributor
Author
|
@mposolda I sent this one with the other fix already merged, so I think it's different (it seems that it is just one flaky test failing in admin UI). Please re-run when finished. If I see that it fails again I will rebase it. |
This was referenced Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #43853
The logout endpoint, when logging out out of band using the
id_token_hint, should take into account the auth session in case it still exists. For that thecreateOrJoinLogoutSessionshould be called after, when the user session is known. This way, we are doing the same that is executed for the refresh token, or when deleting a session using the admin console, thebackchannelLogoutis executed with the user session is passed (here). New test added with the very specific conditions needed to reach this issue.