Refactor KubernetesIdentityProvider#43967
Conversation
slaskawi
left a comment
There was a problem hiding this comment.
LGTM overall but I think we should expose the Clock Time Skew configuration parameter in the Kubernetes IdP Configuration UI as well.
Not sure, there's also the maximum expiration that could be configurable. My thinking was to leave this non-configurable until someone requests it. In either case I'm not going to update the UI as part of this PR. |
ryanemerson
left a comment
There was a problem hiding this comment.
Overall LGTM, just a couple of nitpicks and KubernetesClientAuthTest is failing on CI.
services/src/main/java/org/keycloak/broker/kubernetes/KubernetesIdentityProvider.java
Outdated
Show resolved
Hide resolved
services/src/main/java/org/keycloak/broker/kubernetes/KubernetesIdentityProvider.java
Outdated
Show resolved
Hide resolved
Closes keycloak#43966 Signed-off-by: stianst <[email protected]>
c1abec7 to
5f8a04b
Compare
Test should be fixed now |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
mposolda
left a comment
There was a problem hiding this comment.
Approving ob behalf of @ryanemerson and @slaskawi reviews.
Closes #43966
Signed-off-by: stianst [email protected]