Hide read-only email attribute in update profile context with update … …email enabled #43024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stianst
requested changes
Sep 30, 2025
Contributor
stianst
left a comment
There was a problem hiding this comment.
Do not use style directly in html.
de34515 to
67df2b3
Compare
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.webauthn.account.WebAuthnSigningInTest#setUpLinksTestKeycloak CI - WebAuthn IT (firefox) |
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.account.AccountRestServiceTest#listApplicationsWithoutPermissionKeycloak CI - Java Distribution IT (windows-latest - temurin - 17) |
07ca2cb to
35e1e27
Compare
…email enabled Closes keycloak#42990 Signed-off-by: Martin Kanis <[email protected]>
…d more tests Signed-off-by: Pedro Igor <[email protected]>
pedroigor
approved these changes
Oct 7, 2025
stianst
approved these changes
Oct 7, 2025
martin-kanis
added a commit
to martin-kanis/keycloak
that referenced
this pull request
Oct 7, 2025
…… …email enabled (keycloak#43024) * Hide read-only email attribute in update profile context with update email enabled Closes keycloak#42990 Signed-off-by: Martin Kanis <[email protected]> * Simplifying conditions when checking read/write on email attribute and more tests Signed-off-by: Pedro Igor <[email protected]> --------- Signed-off-by: Martin Kanis <[email protected]> Signed-off-by: Pedro Igor <[email protected]> Co-authored-by: Pedro Igor <[email protected]> (cherry picked from commit a493213)
pedroigor
added a commit
that referenced
this pull request
Oct 7, 2025
…… …email enabled (#43024) * Hide read-only email attribute in update profile context with update email enabled Closes #42990 Signed-off-by: Martin Kanis <[email protected]> * Simplifying conditions when checking read/write on email attribute and more tests Signed-off-by: Pedro Igor <[email protected]> --------- Signed-off-by: Martin Kanis <[email protected]> Signed-off-by: Pedro Igor <[email protected]> Co-authored-by: Pedro Igor <[email protected]> (cherry picked from commit a493213)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #42990