ExternalLinksTest is broken due to missing path parameters#43083
ExternalLinksTest is broken due to missing path parameters#43083ahus1 merged 2 commits intokeycloak:mainfrom
Conversation
| This allows you to better assess where CPU resources are used, and can feed into your sizing calculations. | ||
|
|
||
| See https://www.keycloak.org/observability/metrics-for-troubleshooting-http[Keycloak metrics] and https://www.keycloak.org/high-availability/concepts-memory-and-cpu-sizing#_measuring_the_activity_of_a_running_keycloak_instance[Concepts for sizing CPU and memory resources] for more details. | ||
| See https://www.keycloak.org/observability/metrics-for-troubleshooting-http[Keycloak metrics] and https://www.keycloak.org/high-availability/single-cluster/concepts-memory-and-cpu-sizing#single-cluster-measture-running-instance[Concepts for sizing CPU and memory resources] for more details. |
There was a problem hiding this comment.
Would be good to have the anchor ID named measure instead of measture.
But it'd need to be in the ignored-links for some time (until the website is updated).
|
There are now redirects in place instead. |
| This allows you to better assess where CPU resources are used, and can feed into your sizing calculations. | ||
|
|
||
| See https://www.keycloak.org/observability/metrics-for-troubleshooting-http[Keycloak metrics] and https://www.keycloak.org/high-availability/concepts-memory-and-cpu-sizing#_measuring_the_activity_of_a_running_keycloak_instance[Concepts for sizing CPU and memory resources] for more details. | ||
| See https://www.keycloak.org/observability/metrics-for-troubleshooting-http[Keycloak metrics] and https://www.keycloak.org/high-availability/concepts-memory-and-cpu-sizing[Concepts for sizing CPU and memory resources] for more details. |
There was a problem hiding this comment.
The anchor does not survive during the redirect.
There was a problem hiding this comment.
Thank you for the update. Then let's please update this link and its anchor as needed, and don't rely on the redirect.
|
@ahus1 This is required to pass the test. |
| This allows you to better assess where CPU resources are used, and can feed into your sizing calculations. | ||
|
|
||
| See https://www.keycloak.org/observability/metrics-for-troubleshooting-http[Keycloak metrics] and https://www.keycloak.org/high-availability/concepts-memory-and-cpu-sizing#_measuring_the_activity_of_a_running_keycloak_instance[Concepts for sizing CPU and memory resources] for more details. | ||
| See https://www.keycloak.org/observability/metrics-for-troubleshooting-http[Keycloak metrics] and https://www.keycloak.org/high-availability/concepts-memory-and-cpu-sizing[Concepts for sizing CPU and memory resources] for more details. |
There was a problem hiding this comment.
Thank you for the update. Then let's please update this link and its anchor as needed, and don't rely on the redirect.
| https://www.keycloak.org/high-availability/multi-cluster/* | ||
| https://www.keycloak.org/high-availability/single-cluster/* No newline at end of file |
There was a problem hiding this comment.
Is this a temporary redirect? Which of them are really needed?
Maybe make them more specific. If they are temporary, add a comment until when they are needed.
ahus1
left a comment
There was a problem hiding this comment.
Thank you for the PR. See below for some additional notes.
|
@ahus1 Ok, makes sense. I hope this is what you had in mind. |
Closes keycloak#43082 Signed-off-by: Martin Bartoš <[email protected]>
|
@ahus1 The ExternalLinksTest passed and this should resolve it all. Could you please check it to unblock other PRs? Thanks! |
@mabartos - the external link check is configured to never block any PR as it is not a required check or part of a required check. So please proceed with any other PR while this is in review. |
Signed-off-by: Alexander Schwartz <[email protected]>
ahus1
left a comment
There was a problem hiding this comment.
At the beginning I didn't realize redirects need to be whitelisted as well. I think that should be avoided, so I returned to your earlier variant to update the links. I'm sorry for this detour, approving.
@keycloak/sre Could you check it?
Or rather add the redirect record on the website?