Fix race condition in SAML DocumentBuilderFactory creation #44454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes keycloak#44438 Signed-off-by: martins <[email protected]>
Signed-off-by: Alexander Schwartz <[email protected]>
ahus1
approved these changes
Nov 25, 2025
Contributor
ahus1
left a comment
There was a problem hiding this comment.
Thank you for this fix and the test case. I slightly updated it to use double-locking with a volatile.
Looking at the exception, I also found why this was happening, as the instance variable was filled too early after it wasn't yet fully initialized.
Contributor
|
cc: @keycloak/core-clients for visibility - I'll take care of a backport. |
rmartinc
approved these changes
Nov 25, 2025
Contributor
rmartinc
left a comment
There was a problem hiding this comment.
Thanks @msoderstr for the PR! LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #44438