Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[OID4VCI]: Fix OID4VCI scope save to drop empty fields and apply defaults #44874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mposolda merged 3 commits into from
Jan 12, 2026
Merged

[OID4VCI]: Fix OID4VCI scope save to drop empty fields and apply defaults #44874

mposolda merged 3 commits into from
Jan 12, 2026
+100 −2

Conversation

@forkimenjeckayang
Copy link
Contributor

@forkimenjeckayang forkimenjeckayang commented Dec 12, 2025 •
edited by mposolda
Loading

Description

  • Strip empty optional OID4VCI attributes on save so backend defaults (scope-name fallbacks, realm algs) apply instead of storing empty strings.
  • Keep dropdown-backed fields untouched; retain existing defaulted values (format, lifetime, visible claims, token JWS type, etc.).
  • Add Playwright coverage to ensure optional fields left blank remain empty on reload (not persisted).

Testing

  • Created OID4VCI scope with blank optional fields; saved and reloaded — optional inputs stay blank, defaults remain intact.
  • Existing OID4VCI tests pass.

closes #44846
closes #44807

Depends on

@forkimenjeckayang forkimenjeckayang requested review from a team as code owners December 12, 2025 10:36
This was referenced Dec 12, 2025
Closed
Draft
@forkimenjeckayang forkimenjeckayang marked this pull request as draft December 15, 2025 14:44
@forkimenjeckayang forkimenjeckayang mentioned this pull request Dec 16, 2025
Closed
2 tasks
@forkimenjeckayang
revert CryptoUtils.java to main veraion
0c24d67 
Signed-off-by: forkimenjeckayang <[email protected]>
@forkimenjeckayang
fix failing test
bedbaeb 
Signed-off-by: forkimenjeckayang <[email protected]>
@forkimenjeckayang forkimenjeckayang marked this pull request as ready for review January 9, 2026 15:01
@Awambeng Awambeng mentioned this pull request Jan 12, 2026
Merged
@mposolda mposolda self-assigned this Jan 12, 2026
mposolda
mposolda approved these changes Jan 12, 2026
View reviewed changes
Copy link
Contributor

@mposolda mposolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@forkimenjeckayang Thanks!

@mposolda mposolda merged commit f9d20b8 into keycloak:main Jan 12, 2026
60 checks passed
stianst pushed a commit to stianst/keycloak that referenced this pull request Jan 14, 2026
@forkimenjeckayang @stianst
[OID4VCI]: Fix OID4VCI scope save to drop empty fields and apply defa…
92ac627 
…ults (keycloak#44874)

closes keycloak#44846
closes keycloak#44807

Signed-off-by: forkimenjeckayang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mposolda mposolda mposolda approved these changes

Assignees

@mposolda mposolda

Labels

team/cloud-native team/core-clients team/core-iam team/ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[OID4VCI]: Ensure OID4VCI optional fields are saved cleanly and use defaults [OID4VCI] Default values are not set for ClientScope

2 participants

@forkimenjeckayang @mposolda