Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mabartos
Copy link
Contributor

@mabartos mabartos commented Nov 20, 2025

Signed-off-by: Rahul Jain [email protected]
(cherry picked from commit 61b1e53)

Needs to wait for the prod pieces of Quarkus.

@mabartos mabartos requested a review from a team as a code owner November 20, 2025 14:38
@mabartos mabartos added the status/hold PR should not be merged. On hold for later. label Nov 20, 2025
@VinodAnandan
Copy link
Contributor

@mabartos Could you please share the reason for keeping this PR on hold labeled? Also, do you have an approximate timeline for the next Keycloak 26.4.x patch release (26.4.6?) that will include this PR ?

@vmuzikar
Copy link
Contributor

@VinodAnandan We need to align the upgrade with some downstream bits. Sorry for the confusion and thanks for understanding.

@stianst stianst force-pushed the backport-44348-26.4 branch from b92b213 to 68a0ff5 Compare November 25, 2025 17:59
@stianst stianst self-assigned this Nov 25, 2025
@stianst stianst removed the status/hold PR should not be merged. On hold for later. label Nov 25, 2025
Closes keycloak#43643
Signed-off-by: Rahul Jain <[email protected]>
(cherry picked from commit 61b1e53)
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.BruteForceTest#testNoFailureResetForPermanentLockout

Keycloak CI - Base IT (5)

java.lang.AssertionError: 
type
Expected: is "LOGIN_ERROR"
     but: was "USER_DISABLED_BY_PERMANENT_LOCKOUT"
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
...

Report flaky test

@stianst stianst merged commit 56d2434 into keycloak:release/26.4 Nov 26, 2025
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants