fix(admin-ui): fix setFileUpload implementation to correctly display … #45489
+9
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…filename (keycloak#45488) Signed-off-by: jschae23 <[email protected]>
edewit
approved these changes
Jan 16, 2026
Signed-off-by: Alexander Schwartz <[email protected]>
ahus1
approved these changes
Jan 16, 2026
Contributor
ahus1
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #45488
The FileUploadForm component now correctly preserves the filename during file upload by using functional state updates throughout. Previously, rapid successive state changes (filename, loading status, file content) would overwrite each other due to stale state closures, causing the filename to be lost.
All setState calls now use the functional update pattern prev => ({ ...prev, ... }) to ensure each update builds on the current state rather than captured state from closure creation.