Fix: Prevent brute force counter increment on session limit denial #45541
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed from context.failure() to context.forceChallenge() in DENY_NEW_SESSION case - Updated event error from GENERIC_AUTHENTICATION_ERROR to ACCESS_DENIED - Updated test to match new ACCESS_DENIED error for session limit denial - Prevents users with valid credentials from being locked out due to session limits - Session limit denial is now treated as a policy challenge, not authentication failure Fixes: keycloak#44474 Signed-off-by: Sabeer Muhaiadeen N <[email protected]>
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.webauthn.account.WebAuthnSigningInTest#multipleSecurityKeys |
Author
|
Flaky test reported: #45546 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause
Users with valid credentials were being locked out when hitting session limits because the system treated session denials as authentication failures, incrementing the brute force counter.
Solution
Changed DENY_NEW_SESSION handling from context.failure() to context.forceChallenge()
Updated error event from GENERIC_AUTHENTICATION_ERROR to ACCESS_DENIED
Updated tests to match new error behavior
Impact
Session limit denials no longer increment brute force counters, preventing legitimate users from being locked out due to session limits.
Fixes: #44474