Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@edewit
Copy link
Contributor

@edewit edewit commented Jan 20, 2026

instead of hard coded "resource" we should use the type of permission

fixes: #45428

instead of hard coded "resource" we should use the type of permission

fixes: keycloak#45428
@edewit edewit requested review from a team as code owners January 20, 2026 17:03
@pedroigor
Copy link
Contributor

Thanks, @edewit. Failures seem related?

@muhammedogz
Copy link
Contributor

muhammedogz commented Jan 21, 2026

Hello @edewit, Thanks for working on this solution, I appreciate the approach.

I had also opened a PR targeting the same behavior, but with a slightly different direction. In my version, I tried to reuse the existing type, whereas this approach introduces an additional field. Both seem viable, so I'm happy to adapt my changes if we want to converge on a single solution.

As a small type-safety improvement, we could also consider using type?: "resource" | "scope" instead of a plain string.

@edewit
Copy link
Contributor Author

edewit commented Jan 21, 2026

closed in favor of #45429

@edewit edewit closed this Jan 21, 2026
@edewit
Copy link
Contributor Author

edewit commented Jan 21, 2026

@muhammedogz closed this one in favor of your PR, sorry didn't notice yours I think it's fine like you have it. We could make the types nicer, but atm they are generated from the java model classes and in the future they will contain more information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Admin UI: Wrong redirect for permissions accessed via resource details

3 participants