Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add abstract property for themes and do not display base for selection #45627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mposolda merged 1 commit into from
Jan 21, 2026
Merged

Add abstract property for themes and do not display base for selection #45627

mposolda merged 1 commit into from
Jan 21, 2026

Conversation

@rmartinc
Copy link
Contributor

@rmartinc rmartinc commented Jan 21, 2026

Closes #41924

The PR adds an abstract property to themes that avoids adding that theme to the server-info response. All the base themes are tagged as abstract now. Two comments:

  1. I have not validated the data when the realm is updated/created. It can bring some issues and I prefer this way.
  2. The base theme is OK for email and login (in email base and keycloak are the same, and in login base is just the plain html without any styling), only admin and account are really broken. But the PR adds the property to all the base themes (account, admin, login and email). If you think that only admin and account should be tagged as abstract, just let me know.

@rmartinc rmartinc requested review from a team as code owners January 21, 2026 08:45
mposolda
mposolda reviewed Jan 21, 2026
View reviewed changes
Copy link
Contributor

@mposolda mposolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmartinc Thanks! Added only minor comment inline (which I don't think it is a blocker for this PR).

Besides that, I also think that it is OK that login and email base themes are also abstract. Just wondering if we want to document in upgrading guide (maybe in "noticeable changes") just to be on safe side for the case when someone already uses base as the login theme for example?

For example I wonder about the corner-case scenario like this:

  • Admin already has base theme configured as login theme from previous Keycloak version
  • Now he migrates to latest version
  • Then he wants to update email theme (not login theme) from the admin console. Will he be able to update just the email theme and still keep login theme as base ? If not (and he is forced to update login theme as well) then IMO it would be really good to document this.

@mposolda mposolda self-assigned this Jan 21, 2026
@rmartinc
Copy link
Contributor Author

rmartinc commented Jan 21, 2026

@mposolda I did a quick test, if you have base now in any theme in the admin console it appears empty.

Screenshot From 2026-01-21 11-58-56

And you can change it or maintain it with the wrong (not available). You can save the realm with another theme changed and the old value base is maintained. But I'm going to add a little upgrading note just in case.

@rmartinc
Copy link
Contributor Author

rmartinc commented Jan 21, 2026

@mposolda Upgrading note added.

mposolda
mposolda approved these changes Jan 21, 2026
View reviewed changes
Copy link
Contributor

@mposolda mposolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmartinc Thanks for the update and checking the scenario!

@mposolda mposolda merged commit 7e20b87 into keycloak:main Jan 21, 2026
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mposolda mposolda mposolda approved these changes

Assignees

@mposolda mposolda

Labels

team/ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Internal server error after changing Admin UI theme to "base" - An old, persisted problem

2 participants

@rmartinc @mposolda