Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[BACKPORT] 45417 fixed unmanaged attributes to not allow writing when only admin can view policy is enabled #45637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahus1 merged 1 commit into from
Jan 21, 2026
Merged

[BACKPORT] 45417 fixed unmanaged attributes to not allow writing when only admin can view policy is enabled #45637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions server-spi-private/src/main/java/org/keycloak/userprofile/DefaultAttributes.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,20 +260,16 @@ public Map<String, List<String>> getWritable() {
Map<String, List<String>> attributes = new HashMap<>(this);

for (String name : nameSet()) {
AttributeMetadata metadata = getMetadata(name);
RealmModel realm = session.getContext().getRealm();

if ((UserModel.USERNAME.equals(name) && realm.isRegistrationEmailAsUsername())
|| isReadableOrWritableDuringRegistration(name)
|| !isManagedAttribute(name)) {
if ((UserModel.USERNAME.equals(name) && realm.isRegistrationEmailAsUsername())) {
continue;
}

if (metadata == null || !metadata.canEdit(createAttributeContext(metadata))) {
if (isReadOnly(name)) {
attributes.remove(name);
}
}

return attributes;
}

Expand Down
72 changes: 72 additions & 0 deletions tests/base/src/test/java/org/keycloak/tests/admin/user/UserAttributesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,18 @@
import org.hamcrest.Matchers;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;

import org.keycloak.admin.client.resource.UserProfileResource;
import org.keycloak.models.LDAPConstants;
import org.keycloak.models.UserModel;
import org.keycloak.representations.idm.ErrorRepresentation;
import org.keycloak.representations.idm.RealmRepresentation;
import org.keycloak.representations.idm.UserRepresentation;
import org.keycloak.representations.userprofile.config.UPConfig;
import org.keycloak.testframework.annotations.KeycloakIntegrationTest;
import org.keycloak.testframework.server.KeycloakServerConfig;
import org.keycloak.testframework.server.KeycloakServerConfigBuilder;
import org.keycloak.testsuite.util.userprofile.UserProfileUtil;

import java.util.ArrayList;
import java.util.Collections;
Expand Down Expand Up @@ -142,6 +146,74 @@ public void attributes() {
assertEquals(1, user1.getAttributes().size());
}

@Test
public void unmanagedAttributes() {
UserProfileResource userProfileRes = managedRealm.admin().users().userProfile();
UserProfileUtil.enableUnmanagedAttributes(userProfileRes);
adminEvents.poll();

UserRepresentation user1 = new UserRepresentation();
user1.setUsername("user1");
user1.singleAttribute("attr1", "value1");
user1.singleAttribute("unmanaged1", "value2");
String user1Id = createUser(user1);

//check visibility of attributes depending on unmanaged attribute policy

//with unmanaged attributes enabled, managed and unmanaged attributes are visible
user1 = managedRealm.admin().users().get(user1Id).toRepresentation();
assertEquals(2, user1.getAttributes().size());
assertAttributeValue("value1", user1.getAttributes().get("attr1"));
assertAttributeValue("value2", user1.getAttributes().get("unmanaged1"));

//with unmanaged attributes disabled, only managed attributes are visible
UserProfileUtil.disableUnmanagedAttributes(userProfileRes);
adminEvents.poll();
user1 = managedRealm.admin().users().get(user1Id).toRepresentation();
assertEquals(1, user1.getAttributes().size());
assertAttributeValue("value1", user1.getAttributes().get("attr1"));

//with ADMIN_EDIT policy, managed and unmanaged attributes are visible
UserProfileUtil.setUnmanagedAttributesPolicy(userProfileRes, UPConfig.UnmanagedAttributePolicy.ADMIN_EDIT);
adminEvents.poll();
user1 = managedRealm.admin().users().get(user1Id).toRepresentation();
assertEquals(2, user1.getAttributes().size());
assertAttributeValue("value1", user1.getAttributes().get("attr1"));
assertAttributeValue("value2", user1.getAttributes().get("unmanaged1"));

//with ADMIN_VIEW policy, managed and unmanaged attributes are visible
UserProfileUtil.setUnmanagedAttributesPolicy(userProfileRes, UPConfig.UnmanagedAttributePolicy.ADMIN_VIEW);
adminEvents.poll();
user1 = managedRealm.admin().users().get(user1Id).toRepresentation();
assertEquals(2, user1.getAttributes().size());
assertAttributeValue("value1", user1.getAttributes().get("attr1"));
assertAttributeValue("value2", user1.getAttributes().get("unmanaged1"));

//check updating of attributes depending on unmanaged attribute policy

//with ADMIN_VIEW policy, only managed attributes can be updated
user1.singleAttribute("attr1", "updated1");
user1.singleAttribute("unmanaged1", "updated2");
user1.singleAttribute("unmanaged2", "value3");
updateUser(managedRealm.admin().users().get(user1Id), user1);
user1 = managedRealm.admin().users().get(user1Id).toRepresentation();
assertEquals(2, user1.getAttributes().size());
assertAttributeValue("updated1", user1.getAttributes().get("attr1"));
assertAttributeValue("value2", user1.getAttributes().get("unmanaged1"));

//with ADMIN_EDIT policy, managed and unmanaged attributes can be updated
UserProfileUtil.setUnmanagedAttributesPolicy(userProfileRes, UPConfig.UnmanagedAttributePolicy.ADMIN_EDIT);
adminEvents.poll();
user1.singleAttribute("unmanaged1", "updated2");
user1.singleAttribute("unmanaged2", "value3");
updateUser(managedRealm.admin().users().get(user1Id), user1);
user1 = managedRealm.admin().users().get(user1Id).toRepresentation();
assertEquals(3, user1.getAttributes().size());
assertAttributeValue("updated1", user1.getAttributes().get("attr1"));
assertAttributeValue("updated2", user1.getAttributes().get("unmanaged1"));
assertAttributeValue("value3", user1.getAttributes().get("unmanaged2"));
}

@Test
public void updateUserWithReadOnlyAttributes() {
// Admin is able to update "usercertificate" attribute
Expand Down
10 changes: 9 additions & 1 deletion ...s/utils-shared/src/main/java/org/keycloak/testsuite/util/userprofile/UserProfileUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,16 @@ public static UPConfig setUserProfileConfiguration(RealmResource testRealm, Stri
}

public static UPConfig enableUnmanagedAttributes(UserProfileResource upResource) {
return setUnmanagedAttributesPolicy(upResource, UPConfig.UnmanagedAttributePolicy.ENABLED);
}

public static UPConfig disableUnmanagedAttributes(UserProfileResource upResource) {
return setUnmanagedAttributesPolicy(upResource, null);
}

public static UPConfig setUnmanagedAttributesPolicy(UserProfileResource upResource, UPConfig.UnmanagedAttributePolicy policy) {
UPConfig cfg = upResource.getConfiguration();
cfg.setUnmanagedAttributePolicy(UPConfig.UnmanagedAttributePolicy.ENABLED);
cfg.setUnmanagedAttributePolicy(policy);
upResource.update(cfg);
return cfg;
}
Expand Down
Loading