Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Comments

[OID4CVI] Review and fix issuance on public clients#45855

Open
tdiesler wants to merge 5 commits intokeycloak:mainfrom
tdiesler:ghi45851
Open

[OID4CVI] Review and fix issuance on public clients#45855
tdiesler wants to merge 5 commits intokeycloak:mainfrom
tdiesler:ghi45851

Conversation

@tdiesler
Copy link
Contributor

@tdiesler tdiesler commented Jan 29, 2026

closes #45851

The PR ...

  • adds a public client test-app-pub to testrealm.json
  • adds a comprehensive test using the new OAuthClient APIs (i.e. OID4VCPublicClientTest)
  • adds support for error page/redirect to the AuthorizationRequest
  • removes dependency on OID4VCIssuerEndpointTest.getCredentialOfferUriUrl()

while working on this, I discovered these follow up issues ...

  • Pre-Auth TokenRequest does not natively support OID4VCAuthorizationDetail
  • Pre-Auth AccessToken does not have expected scopes [openid, oid4vc_natural_person_jwt] (still works)
  • Issuer AccessToken does not contain credential-offer-create role (still works)
  • OAuthClient.doLogin cannot handle error page/redirect

Depends on #46356

@tdiesler tdiesler requested review from a team as code owners January 29, 2026 10:40
@tdiesler tdiesler marked this pull request as draft January 29, 2026 14:55
@tdiesler tdiesler changed the title [OID4CVI] No test coverage for public clients [OID4CVI] Review and fix issuance on public clients Jan 30, 2026
@tdiesler tdiesler force-pushed the ghi45851 branch 14 times, most recently from 200c89c to b3986fc Compare February 4, 2026 17:24
@tdiesler tdiesler force-pushed the ghi45851 branch 5 times, most recently from 93aba85 to 732aaca Compare February 17, 2026 08:47
@tdiesler tdiesler marked this pull request as ready for review February 17, 2026 09:11
@tdiesler tdiesler force-pushed the ghi45851 branch 5 times, most recently from 525f9ef to 050fe84 Compare February 18, 2026 05:25
@tdiesler tdiesler force-pushed the ghi45851 branch 4 times, most recently from 483865b to 04da25a Compare February 19, 2026 17:20
@tdiesler tdiesler closed this Feb 21, 2026
@tdiesler tdiesler deleted the ghi45851 branch February 21, 2026 09:47
@tdiesler tdiesler restored the ghi45851 branch February 21, 2026 10:39
@tdiesler tdiesler reopened this Feb 21, 2026
@tdiesler tdiesler force-pushed the ghi45851 branch 3 times, most recently from 4bf7a54 to 509423a Compare February 21, 2026 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[OID4CVI] Review and fix issuance on public clients

1 participant