Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Migrate parts of model package to new test framework #45024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stianst merged 1 commit into from
Dec 19, 2025
Merged

Migrate parts of model package to new test framework #45024

stianst merged 1 commit into from
Dec 19, 2025

Conversation

@stianst
Copy link
Contributor

@stianst stianst commented Dec 19, 2025 •
edited
Loading

Closes #44983

@stianst stianst requested review from a team as code owners December 19, 2025 09:09
lhanusov
lhanusov suggested changes Dec 19, 2025
View reviewed changes
Copy link
Contributor

@lhanusov lhanusov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, check the utility placement. Thanks

@stianst stianst force-pushed the migrate-model-package branch 2 times, most recently from 14b5aa6 to 421eb98 Compare December 19, 2025 09:52
@stianst stianst force-pushed the migrate-model-package branch 2 times, most recently from 8b93bd2 to 2985a96 Compare December 19, 2025 10:01
lhanusov
lhanusov suggested changes Dec 19, 2025
View reviewed changes
Copy link
Contributor

@lhanusov lhanusov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remove unused ManagedRealms in the UserModelTest.java file. Thanks

@stianst stianst force-pushed the migrate-model-package branch 2 times, most recently from 815d595 to 1cbb364 Compare December 19, 2025 10:40
lhanusov
lhanusov suggested changes Dec 19, 2025
View reviewed changes
lhanusov
lhanusov approved these changes Dec 19, 2025
View reviewed changes
Copy link
Contributor

@lhanusov lhanusov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stianst stianst force-pushed the migrate-model-package branch from ab47230 to 53bf8eb Compare December 19, 2025 11:19
@stianst stianst linked an issue Dec 19, 2025 that may be closed by this pull request
Migrate model package to new test framework #44983
Closed
@stianst stianst enabled auto-merge (squash) December 19, 2025 11:22
@stianst stianst disabled auto-merge December 19, 2025 13:52
@stianst stianst merged commit 78274cc into keycloak:main Dec 19, 2025
125 of 130 checks passed
@stianst stianst deleted the migrate-model-package branch December 19, 2025 13:52
@pruivo pruivo mentioned this pull request Dec 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lhanusov lhanusov lhanusov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

team/cloud-native team/core-clients team/core-iam

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate model package to new test framework

2 participants

@stianst @lhanusov