Use MIME decoder instead of the default one to replace deprecated Base64 class#45279
Merged
ahus1 merged 1 commit intokeycloak:mainfrom Jan 9, 2026
Merged
Use MIME decoder instead of the default one to replace deprecated Base64 class#45279ahus1 merged 1 commit intokeycloak:mainfrom
ahus1 merged 1 commit intokeycloak:mainfrom
Conversation
…e64 class Closes keycloak#45226 Signed-off-by: rmartinc <[email protected]>
Member
Member
|
@mposolda - I'm reviewing it just now and I'm ok to merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #45226
This is a fix for a regression caused by #43370. The old Base64 class skips some characters (
\n,\tand\rand space itself are -5 in _STANDARD_DECODABET), that are just not considered for decoding (see here). So the Base64 class is more like the mime instead of the normal decoder. This PR changes the the calls that where changed in the previous PR forgetDecoder, this time forgetMimeDecoder. I have added a unit test to check a MIME encoded saml response is also parsed successfully.