Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[OID4VCI] Add OID4VC tests to FIPS suite #45384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mposolda merged 2 commits into from
Jan 21, 2026
Merged

[OID4VCI] Add OID4VC tests to FIPS suite #45384

mposolda merged 2 commits into from
Jan 21, 2026
+4 −5

Conversation

@Awambeng
Copy link
Contributor

@Awambeng Awambeng commented Jan 13, 2026

This commit introduces two new tests, OID4VCJWTIssuerEndpointTest, OID4VCSdJwtIssuingEndpointTest, OID4VCJwtAuthorizationCodeFlowTest and OID4VCSdJwtAuthorizationCodeFlowTest, to the FIPS test suite, enhancing the coverage for OID4VC functionality.

Closes #44105

@Awambeng Awambeng requested review from a team as code owners January 13, 2026 10:29
@Awambeng Awambeng mentioned this pull request Jan 13, 2026
Closed
@Awambeng Awambeng changed the title Add OID4VC tests to FIPS suite [OID4VCI] Add OID4VC tests to FIPS suite Jan 13, 2026
forkimenjeckayang
forkimenjeckayang approved these changes Jan 16, 2026
View reviewed changes
Copy link
Contributor

@forkimenjeckayang forkimenjeckayang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tdiesler
tdiesler reviewed Jan 20, 2026
View reviewed changes
Copy link
Contributor

@tdiesler tdiesler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mposolda mposolda self-assigned this Jan 21, 2026
@mposolda
Copy link
Contributor

mposolda commented Jan 21, 2026

@Awambeng Thanks for adding the tests!

Sorry to ask this, but is it please possible to do some "dummy" change in some Java file to actually make sure that FIPS tests (and other tests) would be triggered for this PR? For example just comment somewhere or add an empty line. As the CI was not triggered for this PR due it has changes only in the fips-suite file and that one does not trigger CI as of now.

Alternatively, you can try to adjust the GH action configurations and make sure that change in the fips-suite file will trigger CI, but not sure if you want to deal with those configs.

Will be also good to rebase the PR.

@Awambeng
Add OID4VC tests to FIPS suite
cabdea3 
- This commit introduces two new tests, OID4VCJWTIssuerEndpointTest and OID4VCSdJwtIssuingEndpointTest, to the FIPS test suite, enhancing the coverage for OID4VC functionality.

Closes keycloak#44105

Signed-off-by: Awambeng Rodrick <[email protected]>

Address @IngridPuppet review comment

Signed-off-by: Awambeng Rodrick <[email protected]>
@Awambeng
Remove unnecesary lines to trigger FIPS tests for oid4vc in PR
ae7771f 
Signed-off-by: Awambeng Rodrick <[email protected]>
@Awambeng
Copy link
Contributor Author

Awambeng commented Jan 21, 2026

@Awambeng Thanks for adding the tests!

Sorry to ask this, but is it please possible to do some "dummy" change in some Java file to actually make sure that FIPS tests (and other tests) would be triggered for this PR? For example just comment somewhere or add an empty line. As the CI was not triggered for this PR due it has changes only in the fips-suite file and that one does not trigger CI as of now.

Alternatively, you can try to adjust the GH action configurations and make sure that change in the fips-suite file will trigger CI, but not sure if you want to deal with those configs.

Will be also good to rebase the PR.

@mposolda Done.

@mposolda
Copy link
Contributor

mposolda commented Jan 21, 2026

@Awambeng Thanks!

@mposolda mposolda merged commit 9990df0 into keycloak:main Jan 21, 2026
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mposolda mposolda mposolda approved these changes

+2 more reviewers

@tdiesler tdiesler tdiesler left review comments

@forkimenjeckayang forkimenjeckayang forkimenjeckayang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mposolda mposolda

Labels

team/cloud-native team/core-clients team/core-iam

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make sure some OID4VCI functionality tested in FIPS mode

4 participants

@Awambeng @mposolda @tdiesler @forkimenjeckayang