Codestin Search App

ruchikajha95 · 2026-02-17T14:34:31Z

Closes #46337

Approach 1:
Added --shutdown-delay=0s", "--shutdown-timeout=1s"

Tested eg: $ time mvn clean test -Dtest=UpdateCommandDistTest

Before changes output:
real 1m57.160s
user 12m21.342s
sys 0m34.469s

After changes output:
real 0m43.130s
user 3m2.158s
sys 0m5.901s

Approach 2:

Added the Added --shutdown-delay=0s", "--shutdown-timeout=1s" implicitly instead of the default options.

...sts/junit5/src/main/java/org/keycloak/it/junit5/extension/KeycloakDistributionDecorator.java

pruivo · 2026-02-19T11:38:05Z

quarkus/tests/junit5/src/main/java/org/keycloak/it/junit5/extension/DistributionTest.java

     * If any option must be set when starting the server.
     */
    String[] defaultOptions() default {};
-


This change should be reverted.

pruivo · 2026-02-19T11:39:10Z

...sts/junit5/src/main/java/org/keycloak/it/junit5/extension/KeycloakDistributionDecorator.java

-
        args.addAll(List.of(config.defaultOptions()));
-
+        if (isStartCommand(args)) {


All changes in this file can be replaced with one line

setEnvVar("KC_SHUTDOWN_DELAY", "0s");

pruivo · 2026-02-19T11:40:07Z

...amework/core/src/main/java/org/keycloak/testframework/server/DistributionKeycloakServer.java

        this.tlsEnabled = tlsEnabled;

        List<String> args = keycloakServerConfigBuilder.toArgs();
+        if (args.stream().noneMatch(arg -> arg.startsWith("--shutdown-delay"))) {


Same here, in the method startKeycloak(), you can add

pb.environment().put("KC_SHUTDOWN_DELAY", "0s");

…fault options Closes keycloak#46337 Signed-off-by: Ruchika <[email protected]>

…citly Closes keycloak#46337 Signed-off-by: Ruchika <[email protected]>

Closes keycloak#46337 Signed-off-by: Ruchika <[email protected]>

vmuzikar · 2026-02-19T17:43:03Z

...in/java/org/keycloak/testsuite/arquillian/containers/AbstractQuarkusDeployableContainer.java

        commands.add("--health-enabled=true"); // expose something to management interface to turn it on

+        // reduce shutdown delay to speed up testsuite execution.
+        env.put("KC_SHUTDOWN_DELAY", "0s");


Here, we could've used the CLI option to be consistent with other options being set here. In this testsuite we don't expect the tests would be overriding this option, so no need for the env var (if that was the motivation to use it over the CLI option in other places.

That said, it's not blocking, it's good as is.

I suggested using the environment variable approach to keep consistent with the other places.
You're right, it doesn't seem possible to overwrite the command list in this class.

If you mean consistent across testsuite, we're inconsistent already how each of them configures KC. The Arquillian testsuite uses CLI options, that was my argument here.

vmuzikar · 2026-02-19T17:51:48Z

...amework/core/src/main/java/org/keycloak/testframework/server/DistributionKeycloakServer.java


        OutputHandler outputHandler;
        try {
+            pb.environment().put("KC_SHUTDOWN_DELAY", "0s");


I think we might want to put this somewhere into default options in the testsuite? @shawkins Do you remember where?

No, I don't recall a place for that.

I think I found it:

keycloak/test-framework/core/src/main/java/org/keycloak/testframework/server/AbstractKeycloakServerSupplier.java

Lines 89 to 94 in 94dc608

private static KeycloakServerConfigBuilder getKeycloakServerConfigBuilder(KeycloakIntegrationTest annotation) {

KeycloakServerConfig serverConfig = SupplierHelpers.getInstance(annotation.config());

KeycloakServerConfigBuilder command = KeycloakServerConfigBuilder.startDev()

.bootstrapAdminClient(Config.getAdminClientId(), Config.getAdminClientSecret())

.bootstrapAdminUser(Config.getAdminUsername(), Config.getAdminPassword());

@lhanusov @stianst Can you please confirm this would be the correct place to provide default config options to the new testsuite?

shawkins

Is this only needed for distribution tests? What about embedded? And in general should start-dev shut down immediately?

pruivo · 2026-02-19T21:02:13Z

@shawkins, we discussed the embedded mode, and we decided to ignore it and focus on making the GH actions faster. Embedded mode is not used by GH actions as far as we know, and it may go away with the new testsutite (?).

We never thought about start-dev, unfortunately 😅. I don't oppose having no delay during shutdown (assuming nobody uses it in production).

shawkins · 2026-02-19T22:11:12Z

@shawkins, we discussed the embedded mode, and we decided to ignore it and focus on making the GH actions faster. Embedded mode is not used by GH actions as far as we know, and it may go away with the new testsutite (?).

Embedded mode is supported with the new testsuite and does seem to be used, just not by GH - cc @stianst @lhanusov

One other thought - is this adding any measurable delay to the operator tests?

vmuzikar · 2026-02-20T07:42:34Z

Embedded is used for local development where speed is also important. It's also important to be consistent across testsuite modes (remote/embedded). So +1 to @shawkins to add this to embedded too.

ruchikajha95 · 2026-02-20T14:05:17Z

Thank you everyone for the insightful discussion.
I acknowledge the importance of ensuring that the shutdown delay configuration applies consistently to both remote and embedded server modes, as highlighted.

Could the team decide to centralize this configuration (e.g., within AbstractKeycloakServerSupplier as referenced), or if there are further changes required to ensure alignment across all test scenarios, I am happy to implement these improvements. Please let me know if you would prefer that I make these updates within this PR, or if it would be better to address them in a subsequent PR.

Thanks again for your thorough review and the collaborative discussion.

cc: @ahus1 , @pruivo , @ryanemerson , @shawkins , @vmuzikar

ruchikajha95 requested a review from pruivo February 18, 2026 15:29

pruivo reviewed Feb 18, 2026

View reviewed changes

...sts/junit5/src/main/java/org/keycloak/it/junit5/extension/KeycloakDistributionDecorator.java Outdated Show resolved Hide resolved

ryanemerson reviewed Feb 19, 2026

View reviewed changes

...sts/junit5/src/main/java/org/keycloak/it/junit5/extension/KeycloakDistributionDecorator.java Outdated Show resolved Hide resolved

pruivo requested changes Feb 19, 2026

View reviewed changes

ruchikajha95 added 6 commits February 19, 2026 13:20

Added the shutdown delay and shutdown timeout for the testcases to de…

fbf7899

…fault options Closes keycloak#46337 Signed-off-by: Ruchika <[email protected]>

Added the shutdown delay and shutdown timeout for the testcases impli…

7e8c5cb

…citly Closes keycloak#46337 Signed-off-by: Ruchika <[email protected]>

Fixed PR review to remove the shutdown-timeout

d8f4acc

Closes keycloak#46337 Signed-off-by: Ruchika <[email protected]>

Fixed PR review to remove duplicate statement.

67a45b5

Closes keycloak#46337 Signed-off-by: Ruchika <[email protected]>

Fixed the migration failure in CI by using env property

ceecc76

Closes keycloak#46337 Signed-off-by: Ruchika <[email protected]>

Fixed the pr review comments

0b6d0ad

Closes keycloak#46337 Signed-off-by: Ruchika <[email protected]>

ruchikajha95 force-pushed the feature-46337/testcase_0seconds_delay branch from 5c748bc to 0b6d0ad Compare February 19, 2026 13:21

ruchikajha95 added 2 commits February 19, 2026 13:32

reverted changes wrt the additional line

eaf7805

Closes keycloak#46337 Signed-off-by: Ruchika <[email protected]>

Fixed testcase failure

79486d8

Closes keycloak#46337 Signed-off-by: Ruchika <[email protected]>

pruivo approved these changes Feb 19, 2026

View reviewed changes

ryanemerson self-requested a review February 19, 2026 17:07

ryanemerson approved these changes Feb 19, 2026

View reviewed changes

ryanemerson marked this pull request as ready for review February 19, 2026 17:08

ryanemerson requested review from a team as code owners February 19, 2026 17:08

keycloak-github-bot bot added team/cloud-native team/core-clients team/core-iam labels Feb 19, 2026

ryanemerson enabled auto-merge (squash) February 19, 2026 17:09

vmuzikar reviewed Feb 19, 2026

View reviewed changes

vmuzikar requested a review from shawkins February 19, 2026 17:52

shawkins reviewed Feb 19, 2026

View reviewed changes

vmuzikar disabled auto-merge February 20, 2026 07:44


		args.addAll(List.of(config.defaultOptions()));

		if (isStartCommand(args)) {

	private static KeycloakServerConfigBuilder getKeycloakServerConfigBuilder(KeycloakIntegrationTest annotation) {
	KeycloakServerConfig serverConfig = SupplierHelpers.getInstance(annotation.config());
	KeycloakServerConfigBuilder command = KeycloakServerConfigBuilder.startDev()
	.bootstrapAdminClient(Config.getAdminClientId(), Config.getAdminClientSecret())
	.bootstrapAdminUser(Config.getAdminUsername(), Config.getAdminPassword());

Comments

Conversation

ruchikajha95 commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pruivo Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shawkins left a comment

Choose a reason for hiding this comment

Uh oh!

pruivo commented Feb 19, 2026

Uh oh!

shawkins commented Feb 19, 2026

Uh oh!

vmuzikar commented Feb 20, 2026

Uh oh!

ruchikajha95 commented Feb 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ruchikajha95 commented Feb 17, 2026 •

edited

Loading

pruivo Feb 19, 2026 •

edited

Loading