initial version of the client v2 policy test#46029
Merged
mabartos merged 4 commits intokeycloak:mainfrom Feb 6, 2026
Merged
Conversation
6b96f53 to
3bddb51
Compare
Contributor
fixes: keycloak#46074 Signed-off-by: Erik Jan de Wit <[email protected]>
Contributor
Author
|
@mabartos done, reworded the commit |
Signed-off-by: Martin Bartoš <[email protected]>
mabartos
reviewed
Feb 6, 2026
| @AfterEach | ||
| public void cleanup() throws Exception { | ||
| // Clean up any test clients | ||
| cleanupClient("test-policy-client"); |
Contributor
There was a problem hiding this comment.
It'd be nice to have ManagedRealm for these cases, as we might not care about these cleanups. However, I had some problems to have master realm managed (even with the attachTo) and custom admin clients.
On the other hand, we directly test the master realm, so the test coverage might be a little bit higher.
These test improvements can be done in a follow-up tasks with the help of guys working on the testsuite.
So, it's ok to me as is for now.
Contributor
rest/admin-v2/tests/src/test/java/org/keycloak/tests/admin/client/v2/ClientPoliciesV2Test.java
Show resolved
Hide resolved
mabartos
reviewed
Feb 6, 2026
| * when a policy requires specific authenticators. | ||
| */ | ||
| @Test | ||
| public void testCreateClientWithUnacceptableAuthType() throws Exception { |
Contributor
There was a problem hiding this comment.
@edewit nitpick: it'd be good to not use the prefix "test", as it does not add any added value and is considered as old JUnit approach.
Extract client profile/policy to dedicated method
Signed-off-by: Erik Jan de Wit <[email protected]>
Contributor
mabartos
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #45932
fixes: #46074