Add support for webauthn-authenticate.ftl#185
Conversation
Wow! This one sucks. Certainly more in need of review compared to `login-username.ftl` and `login-password.ftl`...
| // css classes for select-authenticator form | ||
| "kcSelectAuthListClass": ["list-group", "list-view-pf"], | ||
| "kcSelectAuthListItemClass": ["list-group-item", "list-view-pf-stacked"], | ||
| "kcSelectAuthListItemFillClass": ["pf-l-split__item", "pf-m-fill"], |
There was a problem hiding this comment.
Not sure if I did these right
|
Great thanks, Just curious, you do these PRs just to help the project out or do you need them? Or both? |
Little bit of both |
|
Fantastic, thanks for the context |
garronej
left a comment
There was a problem hiding this comment.
Looks great overall.
Just neatpicking. If you can't bother I'll do the changes myself.
|
Thanks for the feedback! A lot of this code is only lightly adapted from the original template, but I'm more than willing to refactor :) |
|
ohhhh, I see! |
|
Yes let's refactor a little bit if you don't mind 😃 I mean, just the things I've pointed out. |
|
Yuck, looking at this again, I'm realizing I should have looked a little more closely at the stuff I was lifting from the original template.... using |
Lots of weird syntax here, and we were using `useCallback` rather than `useConstCallback`.
|
Alright, I think I got everyone |
|
Thank you so much! |
Wow! This one sucks. Certainly more in need of review compared to
login-username.ftlandlogin-password.ftl...