Conversation
Fixes #257 Use make-fetch-happen for the download step. This lib will use `PROXY` and `HTTPS_PROXY` and `NO_PROXY` env vars out of the box. Additionally we'll try and get proxy config from npm. Unfortunately, the most straightforward options is to call npm config to do this, since npm config is not easily extracted as a lib and we don't want to replicate the resolution mechanisms.
|
unfortunately, the newly introduced lib wants to run node LTS only :( this is why some ci runs break |
|
@garronej you could disable the |
|
Wow, great ! Yes let's drop v15 and 17 from the matrix |
|
@lordvlad Fantastic. |
@garronej Not sure I get it. I don't see any RC branches, I could branch from. For the PR I did create a branch |
I'd wait for feedback, as I was only able to test it in a very small setup on localhost. |
Sorry, my bad again, it's a branch indeed! Let's release a candidate then |
|
@lordvlad I'm flattered, but I'm not a maintainer :P |
|
Haha GitHub suggested you and I just rolled with it 😅 |
… into lordvlad/issue257 * 'lordvlad/issue257' of github.com:InseeFrLab/keycloakify: Only test build on LTS node version Update dependency evt to ^2.4.15 Update README.md Bump version Avoid passing unessesary realm values in the error.ftl page
Fixes #257
Use make-fetch-happen for the download step. This lib will use
PROXYand
HTTPS_PROXYandNO_PROXYenv vars out of the box.Additionally we'll try and get proxy config from npm. Unfortunately,
the most straightforward options is to call npm config to do this, since
npm config is not easily extracted as a lib and we don't want to
replicate the resolution mechanisms.