Fix bug where headings get duplicated #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khiga8
commented
Feb 14, 2022
| appendAccessibilityInfo(); | ||
| }); | ||
|
|
||
| appendAccessibilityInfo(); |
Owner
Author
There was a problem hiding this comment.
This method will run on initial page load after DOM is complete.
From Content Script Chrome Docs:
Content scripts running at "document_idle" do not need to listen for the window.onload event, they are guaranteed to run after the DOM is complete. If a script definitely needs to run after window.onload, the extension can check if onload has already fired by using the document.readyState property.
khiga8
commented
Feb 14, 2022
Comment on lines
+38
to
+41
| chrome.runtime.onMessage.addListener(async (message) => { | ||
| document.querySelectorAll(".github-a11y-img-caption").forEach(el => el.remove()); | ||
| document.querySelectorAll(".github-a11y-heading-prefix").forEach(el => el.remove()); | ||
| appendAccessibilityInfo(); |
Owner
Author
There was a problem hiding this comment.
We add event listener to listen for navigation events and clean up DOM & append elements again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the heading levels get appended multiple times to a page when using the back and forth button, or when clicking the tab of a page we're already on multiple times.
To prevent this, we should clean up the DOM whenever
onHistoryStateUpdatedevents are fired (indicating page navigation). We do not need to do this on initial page load.Screenshot of bug