Fix alt overlay issue and deprecate support outside github.com and gist.github.com host.
#13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khiga8
commented
Feb 16, 2022
| opacity: 0.6; | ||
| width: 100%; | ||
| font-size: 0.8rem; | ||
| opacity: 0.8; |
Owner
Author
There was a problem hiding this comment.
Makes font size smaller. Also, sets opacity to 0.8 because 0.6 is too low color contrast.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12
Context
Previously the text overlay was styled to appear over the image. This resulted in text covering the image. Another problem was that when there were multiple images on the same line, the captions for each image will overlap on top of each other.
Instead, we have the text overlay appear below the image and a border outlining the image and overlay to group it together. Additionally, we ensure that the alt text overlay is added when image is nested inside
tableand other elements, not just<p>.This also turns off the extension outside of the
github.comandgist.github.comdomain where support may be wonky.Screenshots
Before:
After: