Update manifest regex #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khiga8
approved these changes
Aug 1, 2023
Owner
khiga8
left a comment
There was a problem hiding this comment.
Thank you so much for catching this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋🏼 @khiga8! Thanks for making this!
It appears as though the previous commit changed the regex so that it would accept more subdomains, however, the syntax
*.*broke the extension so that it could no longer be loaded.For reference: Chrome extensions match patterns
When changed to
*.github.comthe plugin uploads and works (I see it working on the image above).Additionally, I removed
https://gist.github.combecause it's redundant because it is included by the wildcard.